Commit graph

233 commits

Author SHA1 Message Date
Paul Davis
03b32cb4a0 remove unused "beats" variable and computation from Editor::metric_get_bbt() 2023-02-10 11:11:51 -07:00
Robin Gareus
1ff5592731
Remove UI side grid limit
This concept from 2007 is no longer required Temporal::get_grid
already limits the number of grid-lines depending on the step
size (mod-bar, beat_div) and start/end positions.
2023-01-11 00:32:47 +01:00
Paul Davis
8237a8115c cleanup unused variables in Editor ruler display code 2022-12-10 10:48:59 -07:00
Paul Davis
cd86521c65 rulers: improve labelling of non-quarter note beats in tempo ruler 2022-11-29 10:09:39 -07:00
Paul Davis
8b06eb9878 editor rulers: do not try to generate "fill" ticks/lines for the grid
We now generate a grid from the TempoMap of appropriate "density". Doing this
in the editor just gets things wrong (and partially duplicates the (complex)
logic already present in the TempoMap).
2022-11-29 10:09:39 -07:00
Paul Davis
264140c191 do not label ticks generated to fill space between ::get_grid() results 2022-11-22 18:09:46 -07:00
Alexandre Prokoudine
cc912cca1b Make title capitalization consistent across rulers 2022-11-10 15:35:22 +03:00
Paul Davis
6d1e4207de bbt ruler: no more micro/minor mark distinction. all bars are equal between labels 2022-10-31 17:05:55 -06:00
Mads Kiilerich
34527525be
Consistently put ruler toggle code in the same order
Just reordering.
2022-10-24 05:14:58 +02:00
Paul Davis
cf83815133 add clear-all-cues item to cue marker ruler context menu 2022-10-21 07:52:23 -06:00
Paul Davis
0c2176dd71 move default_triggers_per_box into a namespace ; change value for Ardour to 16 (GUI edition) 2022-10-04 19:55:15 -06:00
Paul Davis
0938d21c30 change add new bbt marker from primary-click to context-click on BBT ruler 2022-10-03 14:16:34 -06:00
luz paz
47c525315d Fix various typos
Found via `codespell -q 3 -S *.po,./.git,./share/patchfiles,./libs,./msvc_extra_headers,./share/web_surfaces,*.patch  -L ba,buss,busses,discreet,doubleclick,hsi,ontop,ro,scrollin,seh,siz,sord,sur,te,trough,ue`
2022-08-03 12:10:01 -06:00
Paul Davis
014c6e7850 replace INT32_MAX with CueRecord::stop_all (gui) 2022-08-03 11:42:58 -06:00
Robin Gareus
8ead1439d8
Fix ruler/canvas separator
The track-header (gtk) is packed with 1px box spacing. This
is added at the top of each box (best seen by looking at the
group-tab vs track-header alignment in the editor).

However the actual track separator line on the canvas is at the
bottom of each track, aligning with the top of the next track
or automation-lane.

The first track however lacks a separator at the top, which
needs to be provided by the ruler. Once the canvas is scrolled
this ruler/canvas separator overlaps with the bottom separator of
each TAV.

Using ruler Rectangle::set_outline had various issues.
The outline extends outside the rectangle. It bled into the
video-timeline instead of the canvas' top y-axis pixel.

Also the separator was above the video-timeline, not above the
canvas. Hence a dedicated separator Line is preferable.
It also provides a consistent separator if no rulers are visible.
2022-07-06 20:50:06 +02:00
Paul Davis
4b11b2ba28 remove unused item 2022-06-21 16:55:29 -06:00
Paul Davis
0e85655c38 right click on tempo curve should be equivalent to right click on empty bar 2022-06-03 15:02:37 -06:00
Robin Gareus
7e10061d16
Disambiguate "Meter" use "Time Signature for music meter
In general we should use
* "meter": signal level meter
* "time-signature": music meter / metrum
2022-04-05 18:56:10 +02:00
Ben Loftis
897798ed68 remove cue-behavior toggle from ruler context menu 2022-02-12 21:49:57 -06:00
Paul Davis
76ae8f29f7 triggerbox GUI: stop-all cue marker uses INT32_MAX now 2022-02-11 13:37:14 -07:00
Paul Davis
17e5667216 triggerbox: use translatable marker name function in GUI 2022-02-11 11:33:43 -07:00
Ben Loftis
60cbe57a6e Marker Rulers: changes to match mini-timeline aesthetic
Highlight ruler lanes when you enter, instead of showing many lines
2022-01-20 18:59:21 -06:00
Paul Davis
2152e7ba3b triggerbox: change FollowActions into an object with a target list (GUI edition) 2022-01-19 15:50:55 -07:00
Robin Gareus
96137739a7
Reduce includes required for Selection
Previously a triggerbox_ui.h change triggered a complete UI
rebuild. This follows the concept of other editor_selection
lists which use forward declarations.
2022-01-11 05:21:51 +01:00
John Emmas
6750c9b049 Disambiguate a pointer to CheckMenuItem
Windows itself offers its own version of CheckMenuItem
2022-01-07 10:34:11 +00:00
Paul Davis
0baf0d859d GUI side of cue behavior (makes it available in the ruler context menu) 2022-01-06 12:00:18 -07:00
Paul Davis
7c35783d63 various fixes for cue marker creation, dragging, naming 2022-01-05 13:27:47 -07:00
Paul Davis
1d2fa465d3 remove mistaken handling of cue marker bar events 2022-01-05 13:27:47 -07:00
Paul Davis
b1f73d25bf actual GUI interaction for cue marker ruler 2022-01-04 15:23:51 -07:00
Paul Davis
77d83540b1 copy-n-paste addition of cue marker ruler (based on cd marker ruler) 2022-01-04 15:23:51 -07:00
Paul Davis
753d1c9754 rulers: change API to accept a pointer instead of a reference to a Metric
We need to be able to construct Metrics after the ruler is constructed
in order to deal with Triggers which are potentially short-lived. We
stored the reference as a pointer anyway, so it's not as much of a change
as it appears.
2021-12-24 14:17:23 -07:00
Paul Davis
91f38f9c4e remove Session::bbt_time() and use TempoMap::use()->bbt_at() explicitly everywhere (GUI edition) 2021-12-14 21:59:33 -07:00
Ben Loftis
2a6da0113f MIDI Draw: Provide a menu to explicitly select note-length
ToDo: 3,5,7's?  keyboard shortcuts?
2021-11-18 07:35:13 -06:00
Paul Davis
c24cabead0 GUI changes to follow TempoMap::sample_at() API changes 2021-11-17 15:57:30 -07:00
Paul Davis
9531878596 remove incorrectly retained code (post rebase conflict resolution) 2021-08-13 12:51:36 -06:00
Paul Davis
76e5aaea44 remove another NUTEMPO #warning by using TempoMap::count_bars() 2021-08-13 12:51:35 -06:00
Paul Davis
45a8da77f6 clean up rulers/grid mess after rebase on master 2021-08-13 12:51:34 -06:00
Paul Davis
f328fdc56a adapt to DoubleableBeats and so forth (gui edition) 2021-08-13 12:51:32 -06:00
Paul Davis
b757756e92 BBT ruler: fix error in setting beat count 2021-08-13 12:51:32 -06:00
Paul Davis
9412130c01 use cleaned up Temporal ::quarters*_at* API (GUI edition) 2021-08-13 12:51:31 -06:00
Paul Davis
3c00fab75e remove/hide Session::tempo_map() and use TempoMap::use() instead (thread local shared ptr) (GUI edition) 2021-08-13 12:51:30 -06:00
Paul Davis
749a49c278 incorporating new tempo map API 2021-08-13 12:51:29 -06:00
Paul Davis
9d69fa3820 another day or two's work on timeline type conversion 2021-08-13 12:51:29 -06:00
Paul Davis
f4490f54c5 change Timecode::BBT_Time to use Temporal namespace, plus a couple of other minor changes to enable compilation
This still uses the tempo map object in libs/ardour, not the new one in libs/temporal, and isn't likely to be functional
(though it could be)
2021-08-13 12:51:28 -06:00
David Robillard
74e21e942e Remove unused variables (Wunused-variable) 2021-05-30 20:09:35 -04:00
Paul Davis
bcb3e75cec GUI to remove xrun markers 2021-03-16 16:49:49 -06:00
Ben Loftis
e4e21f4d07 snap revisited: somewhat better choice of ruler scale for 3,5,7 2021-02-21 12:14:27 -06:00
Ben Loftis
129e654500 fix(?) rulers for 3,5,7 divisions 2021-02-21 08:18:14 -06:00
Paul Davis
efd0d65acb when window size technically, just the window containing the editor canvas, or the canvas itself) changes, recompute BBT ruler stuff 2021-02-20 17:41:32 -07:00
Ben Loftis
7e196e7559 snap-revisited: Fix occasional variance between the visible ruler and the snap grid
code changes:
  bbt_ variables don't need to be global to editor; we only use these in compute_bbt_ruler_scale now anyway
  drive the ruler with the same coarse-ified bbt_ruler_scale that we calculate for the snap grid
2021-02-20 10:35:36 -06:00