Commit graph

22173 commits

Author SHA1 Message Date
Paul Davis
607f3577bd temporal: in the event of the most common logic failure, provide more info
TEMPORAL_MAP_ASSERT() doesn't give us any actual values or context.
2025-08-20 17:43:24 -06:00
Paul Davis
5aed12b90e in launchkey 4 code, use new Meter::bbt_delta() not ::bbt_delta 2025-08-20 17:43:15 -06:00
Paul Davis
a8168f826d remove incorrect bbt_delta() in BBT_Time, provide Meter::bbt_delta
There are two implementations here, the more efficient one (commented out) does
not work correctly yet.
2025-08-20 17:43:05 -06:00
Paul Davis
0dab69fe74 check for null ActionGroup in ActionManager::drop_action_group() 2025-08-20 14:54:07 -06:00
Robin Gareus
724340ce11
Hide debug messages in optimized builds 2025-08-20 21:42:04 +02:00
Franke Burgarino
8bfd8de2f6 MCU: hide phase/solo controls for master 2025-08-20 10:30:05 -05:00
Robin Gareus
28c8dbf128
Handle special case of using unmanaged widgets to Frame
This happens in in Ardour's Preference dialog with
e.g. BufferingOptions:

~OptionEditorContainer deletes the Option, which in turn
deletes the Widget BufferingOptions:_buffering_presets_combo
Since the widget is not managed it is not removed from its
parent.

Later ~OptionEditorContainer disposes the page layout, which
eventually also calls the Frame d'tor, causing a heap-use-after-free.
2025-08-20 16:19:25 +02:00
Franke Burgarino
2f3c700cd0 MCU: give UF1 & UF8 seperate device configs 2025-08-19 15:36:40 -05:00
Franke Burgarino
25d9c2b284 MCU: add master/monitor to global/mixer view if device has no master fader 2025-08-19 15:36:40 -05:00
Robin Gareus
43e4e428f5
Handle case where a custom MenuElem is added to the dropdown 2025-08-19 20:06:04 +02:00
Paul Davis
469f3e4d2a unit tests: fix an unusual deadlock/block in TempoMap::write_copy()
this call works in other tests, no time to investigate it right now, and
technically the test doesn't require a write copy at all.
2025-08-19 10:53:06 -06:00
Paul Davis
69174b555e unit tests: use std::cout for any debug output in tempo map cut buffer test 2025-08-19 10:53:06 -06:00
Paul Davis
1312e8f992 temporal: implement TempoMap::bbt_distance() but do not use it
This was implemented to try to fix paste() but was not needed. It might be
useful in the future, or just as an expression of the logic of this. Note that
the BBT_Offset it returns only has the beats field set, which is ... odd. So
this is likely not quite finished.
2025-08-19 10:53:06 -06:00
Paul Davis
29be601cce temporal: undefine macro after use 2025-08-19 10:53:06 -06:00
Paul Davis
7c9b9ceb7e temporal: show BBT marker point names in operator<< 2025-08-19 10:53:06 -06:00
Paul Davis
2aad1ac5f5 temporal: fix TempoMap::paste() to pass unit test
the BBT times of the newly inserted points during paste() are meaningless until
we recompute them using ::reset_starting_at(). So don't try to compute some
sort of likely value, just use the value from the cut buffer, and call
reset_starting_at() after every point inserted.
2025-08-19 10:53:06 -06:00
Paul Davis
f0111bcea5 temporal: BBT_Time cannot have any round_to_*() or round_up_to_*() methods
A meter (time signature) is required to do the math correctly for any operation that may
cross or reach the next bar boundary, which round_to_*() and round_up_to_*() may do.
2025-08-19 10:53:06 -06:00
Robin Gareus
4859e4e57e
ArdourDropdown: use action's short-label for display text 2025-08-19 18:18:41 +02:00
Robin Gareus
5f12554b56
YTKMM: expose ytk_set_child_packing 2025-08-19 14:20:39 +02:00
Paul Davis
a48ffdf998 refinements to SMF type0 import logic 2025-08-18 16:46:26 -06:00
Paul Davis
4303b77441 MIDI regions attempt to get their tempo & meter from their source file 2025-08-18 16:35:42 -06:00
Paul Davis
c49f607ce6 slightly refine SMF::is_meta() to differentiate realtime system reset 2025-08-18 16:35:41 -06:00
Paul Davis
79da488132 Reimplement MIDI file import to retain metadata in the files written
Previosuly, all meta data was thrown away. Now we retain it, so that MIDI
regions can ask about their source file's tempo & meter.

Significant engineering rework of how this all works, relying on
recently introduced API and API changes in SMF, SMFSource etc.
2025-08-18 16:35:41 -06:00
Paul Davis
48cd807e6a change API of MidiSource::append_event_beats() to allow meta-event legality
Because we want a default argument of false, this involved the usual
inline-non-virtual-method-calls-virtual-with-no-default trick.

Also, do NOT append data to a MidiModel or change the length of an SMFSource
unless we know for sure that added that data to the SMF object.
2025-08-18 16:35:41 -06:00
Paul Davis
586ac7e447 add SMFSource::end_track() to provide source-level access to SMF method 2025-08-18 16:35:41 -06:00
Paul Davis
73065f814a modify API of Evoral::SMF::append_event_beats() to add meta-event legality
If the (new) final argument is true, we allow writing SMF meta events to the
underlying libsmf object (which doesn't care one way or another).
2025-08-18 16:35:41 -06:00
Paul Davis
b60702e014 add Evoral::SMF::end_track()
This changes the assumption that an SMF object only refers to
a single track when being written.

::end_track() is used within begin::write()/end_write() pairs to mark the start
of a new SMF track.
2025-08-18 16:35:41 -06:00
Paul Davis
785047bf47 add Evoral::SMF::is_meta() to test for SMF meta events
These are not legal in "live" MIDI but are allowed in SMF files.
2025-08-18 16:35:41 -06:00
Paul Davis
e703cf2d73 use nullptr instead of zero in initializer 2025-08-18 16:35:41 -06:00
Paul Davis
a22a84cbee SMF: return meta events, with size set to event size, but return value of zero 2025-08-18 12:47:26 -06:00
Robin Gareus
bdc4d6fb60
Potential fix for MSVC builds 2025-08-17 17:30:22 +02:00
Robin Gareus
26ca954574
Allow to scroll though meta-button items #9976 2025-08-17 06:29:31 +02:00
Robin Gareus
a83c83aef6
Overhaul persistent tooltip position #9979
* directly show at correct position
* honor multi-monitor boundaries
* hide on focus-out (e.g. switch desktops with visible
  tooltip left it visible)
* remove unused `set_center_alignment` API
2025-08-17 02:55:25 +02:00
Robin Gareus
92bcddb437
Emit Signal when MCSS Threads are exhausted
By default Windows has limit of 32 MMCSS threads.
Ardour uses MMCSS scheduling for for hardware I/O (audio and MIDI)
as well as for realtime process threads, and a user on a
recent machine may run into this limit.
2025-08-16 23:11:16 +02:00
Robin Gareus
5ffc3aa28b
Use PBD namespace for free CPU functions
Ideally never put methods in the global namespace
to prevent potential conflicts.
2025-08-15 22:10:31 +02:00
Robin Gareus
b1d5f065db
Add API to query max MMCSS threads on Windows
By default Windows limits the number of MMCSS threads to 32.
This can cause problems on modern systems with >= 32 cores,
when Ardour uses many process and I/O threads.

So far this is just a first step (query API)
2025-08-15 22:02:44 +02:00
Franke Burgarino
1ff9bf3e86 MCU: no track selected message
an attempt to select a track specific subview without having a track
selected now spits out a message instead of just doing nothing
2025-08-14 10:20:01 -05:00
Robin Gareus
0f256cc687
FP8: Add new well-known ctrls 2025-08-14 16:30:53 +02:00
Paul Davis
f010133c5f slightly improve a DEBUG_TRACE message for DEBUG::Grid 2025-08-13 10:51:44 -06:00
Paul Davis
46f2dba306 temporal: fix Meter::to_quarters (BBT_Offset)
Because Paul can't do math
2025-08-13 10:51:44 -06:00
John Emmas
ca820d6380 Remove some unneeded DLL export specifiers (and repo some that were in the wrong place) 2025-08-13 11:22:06 +01:00
Paul Davis
b95c29770c initialize scope owner in default TempoMap constructor
This constructor should not really exist, but it does.
2025-08-12 21:44:50 -06:00
Paul Davis
20b984384d NO-OP: move TempoMap destructor in code to be after constructors 2025-08-12 21:44:50 -06:00
Paul Davis
7539c9e9a8 introducing ARDOUR::string_as_value()
This does more or less the opposite of what value_as_string() does.

Functionally is far from complete, but it is useful even in its current form.
2025-08-12 21:44:50 -06:00
Paul Davis
1362c2b85d auto-ify a loop in ARDOUR::value_as_string()
so much more readable!
2025-08-12 21:44:50 -06:00
Franke Burgarino
7d70dc9384 MCU: implement 'available' parameter list in EQSubview 2025-08-12 17:00:56 -05:00
Franke Burgarino
0af47ff755 MCU: add more comp/gate controls 2025-08-12 13:27:19 -05:00
Robin Gareus
b14ce31372
Consolidate rt processor-changed signal emission
Prefer a single signal and bit flags, instead of individual signals.
This allows to call resort_route() at most once (if at all for
certain changes).

Notably Mixbus comp/gate/eq type changes can use NoProcessorChange
to only request a GUI update.
2025-08-12 19:48:28 +02:00
Franke Burgarino
e734acfa6b MCU: fixed dynamics subview scrolling bug
switching to a dyn type with less parameters can no longer place you past the
last parameter
2025-08-12 11:11:05 -05:00
Franke Burgarino
588fbee13b MCU: move creation of dynamics subview 'available' parameters list to seperate function
'available' was being created and deleted every time setup_vpot was
called. now it is only created when making the subview or switching the
dynamics type
2025-08-12 11:11:05 -05:00