Robin Gareus
eecad55f51
Remove redundant call, fix VST bypass indicator
...
PlugUIBase c'tor already sets the correct value, using
PluginInsert::enabled. That also correctly shows bypass state of VSTs
that support effSetBypass
2019-03-11 04:18:35 +01:00
Robin Gareus
bdcfab73f8
Use VST's print_parameter() when applicable.
2019-03-11 02:56:08 +01:00
Robin Gareus
484e0d0fb2
Remove generic parameter-printer
...
This has been superseded by value_as_string() along with meta-data
from parameter-descriptor, which is supported by all standards, except VST.
2019-03-11 02:10:50 +01:00
Robin Gareus
4964852f0b
Remove cruft, unused variable
2019-03-11 01:49:43 +01:00
Robin Gareus
45805ece02
Remove unused value parameter printers
2019-03-11 01:48:40 +01:00
Olivier Humbert
1df160cbf8
Fixes 2 mistakes in the German translation file
2019-03-09 22:01:43 +01:00
Olivier Humbert
7b9fc3d601
French and German fixes
2019-03-09 22:01:43 +01:00
Robin Gareus
4d695eaf51
Work-around crash when printing bindings
...
(ardour -b or Keyboard-Shortcuts > Print Bindings)
see also https://github.com/Ardour/ardour/pull/447
2019-03-09 21:59:16 +01:00
Paul Davis
65fc37afb7
do not save MIDI port info unnecessarily
2019-03-08 17:51:00 -07:00
Paul Davis
d14d9d9532
on engine (re)start, just mark MIDI port info dirty
2019-03-08 17:50:32 -07:00
Paul Davis
c51c8b3308
add runtime warning message
2019-03-08 17:08:29 -07:00
Paul Davis
4c2e801b5f
avoid crazy levels of work when MIDI Port Info preferences panel is not visible
2019-03-08 17:04:43 -07:00
Paul Davis
b1504f261e
drop silly canonical name stuff from MIDI port info, and just store backend name (GUI version)
2019-03-08 12:10:32 -07:00
Paul Davis
dd8b051636
drop silly canonical name stuff from MIDI port info, and just store backend name (libs version
2019-03-08 12:10:22 -07:00
Paul Davis
ae997c0935
rework name/canonical-name stuff for MIDI port info (GUI edition)
2019-03-07 22:05:40 -07:00
Paul Davis
ac50d66da9
rework name/canonical-name stuff for MIDI port info
2019-03-07 22:05:40 -07:00
Olivier Humbert
6dcfc7b7f0
French translation update
2019-03-08 02:43:34 +01:00
Robin Gareus
2e5daf2eeb
Reduce #includes - avoid ardour_ui.h
2019-03-08 01:53:55 +01:00
Robin Gareus
d42c0f2d60
Fix some more Gtk::Menu memory leaks
2019-03-08 01:44:51 +01:00
Robin Gareus
15cd1163fc
Pass stderr mode properly to vfork wrapper
2019-03-07 23:51:04 +01:00
Robin Gareus
df8097e31e
Fix mp3 export
...
For reasons yet to be investigated, closing stderr when using a
pipe into ffmpeg results in ffmpeg's stderr being written
verbatim in the output file.
2019-03-07 23:51:01 +01:00
Robin Gareus
7ed27e3ef7
Request for comment: Bug or feature?
2019-03-07 23:50:59 +01:00
Robin Gareus
7b96fa1c5e
Fix some Gtk::Menu memory leaks
...
A Gtk::manage()d widget will be deleted when its parent container
is destroyed. Top-level context menus are not inside a container and
hence need to be manually deallocated.
The solution here is to use a shared Gtk::Menu pointer that is
centrally de/re-allocated.
This works because the GUI is single-threaded and at most one
context menu is visible at a time.
2019-03-07 23:50:50 +01:00
Robin Gareus
12a415f077
Cleanup Editor/Marker context-menu
...
This could have caused crashes previously:
::build_range_marker_menu() may have created range_marker_menu
while the GUI wanted transport_marker_menu.
2019-03-07 23:50:46 +01:00
Robin Gareus
64e1d691ec
Prefer using RAII to suspend signals
2019-03-07 23:50:43 +01:00
Robin Gareus
3bc9281c31
Fix some Gtk::Menu related memory leaks
...
A Gtk::manage()d widget will be deleted when its parent container
is destroyed. Top-level context menus are not inside a container and
hence need to be manually deallocated.
This adds explicit delete calls for menus where there is a
member variable reference to the Menu.
2019-03-07 23:50:32 +01:00
Robin Gareus
204d7bf76c
Remove cruft: unused members
2019-03-07 22:25:19 +01:00
Robin Gareus
b410cd07ab
Remove unused region_edit_menu & edit-point action
2019-03-07 22:25:19 +01:00
Paul Davis
99462a50e6
save/restore MIDI port pretty names, but prefer backend pretty name if available
2019-03-07 13:30:54 -07:00
Paul Davis
10bc824032
selection must be enabled to allow editable columns :((
2019-03-07 13:30:24 -07:00
Paul Davis
d301bef742
redesign naming and reload of MIDI port information (GUI edition)
2019-03-07 12:01:27 -07:00
Paul Davis
f7802325dc
redesign naming and reload of MIDI port information (library edition)
2019-03-07 12:01:27 -07:00
Paul Davis
8b212bfa12
a more nuanced version of the "do-not-automatically-disconnect-selection-follows-input
2019-03-07 12:01:27 -07:00
Ben Loftis
66f73f40db
Fix thinko: if the entered_regionview is already part of the selection, do not treat it as a special case when splitting.
2019-03-07 09:50:00 -06:00
Robin Gareus
b774ef1e20
Remove unused fluidsynth setting (since fluidsynth 2.0)
2019-03-06 23:50:07 +01:00
Robin Gareus
ce961d73f3
Use unique midi-port names for Ardour's Dummy backend
2019-03-06 23:48:07 +01:00
Robin Gareus
8ccc45d44d
Ardour/ALSA allow multiple MIDI devices with the same name
2019-03-06 23:41:15 +01:00
Robin Gareus
210d03a477
Retain generated plugin menu
...
Fixes occasional crash when Menu is re-used.
PluginSelector::plugin_menu() is called every time the processor box
shows the context-menu. The provided menu needs to remain valid
regardless of usage.
2019-03-06 21:21:29 +01:00
Robin Gareus
51674b0307
Add missing newline on error message
2019-03-06 17:09:29 +01:00
Robin Gareus
a24252e0d0
Fix typo
2019-03-06 17:09:12 +01:00
Jan Lentfer
dfda5eab82
LCXL:Disable global mute/solo/recarm in device mode
2019-03-06 09:28:25 +01:00
Robin Gareus
1af123465c
Tweak session load
...
Listen positions are already correctly set when the route state
is restored. The Route directly uses the Config.
This skips duplicate calls to re-configure all processors on all Routes
during RCConfiguration::map_parameters() on session-load, twice
(pfl-position, listen-position)
2019-03-06 01:04:29 +01:00
Robin Gareus
883ee9c2a0
Allow to call set_state() on existing routes
...
Delaylines are not saved in the XML and internal-return is an
invisible processor not explicitly re-added when the state is restored.
They are [re]inserted during Route::setup_invisible_processors().
So this method need to be called after restoring processor state
(indirectly via configure_processors_unlocked as needed).
PS. During route creation this call happens explicitly and on session load
hookup_io() -> Route::output_change_handler() implicitly sets this up.
2019-03-06 00:57:49 +01:00
Robin Gareus
2bfe0c6ff7
Properly map MonitorSection state on session load
2019-03-06 00:47:59 +01:00
Robin Gareus
6a7750a55d
Tweak, optimize route setup
...
Speed up route creation: add_processor() takes a process-lock
and calls configure_processors() but this is done explicitly at the
end of init() already.
2019-03-06 00:03:46 +01:00
Robin Gareus
8b5437301b
Close stderr of child processes on MacOS
...
This fixes a bug on some modern mac systems. Related to
setup_logging() changing stderr to use ASL and write to com.apple.console.
When a forked application writes to stderr while ASL is used,
the child is terminated for some reason.
2019-03-05 22:52:53 +01:00
Robin Gareus
a390d8d3ca
Use enum for exec stderr parameter (2/2)
2019-03-05 22:49:18 +01:00
Robin Gareus
e1ffe7857f
Use enum for exec stderr parameter (1/2)
2019-03-05 22:49:15 +01:00
Robin Gareus
fdf74cf850
Enable de-click in disk-reader
...
This breaks auto-return and other post-transport locates until
such transport-states wait for de-click before seek().
2019-03-05 22:49:08 +01:00
Paul Davis
f1dfc6d2a2
do not disconnect MidiPortSelection-flagged ports from everything when (MIDI track) selection changes
...
If the user manually connects such a port to something, then it is
up the user to disconnect it too
2019-03-04 18:23:06 -07:00
