Commit graph

13207 commits

Author SHA1 Message Date
Paul Davis
918eacdfa7 NOOP: remove newlines 2020-03-27 12:40:44 -06:00
Paul Davis
ef3c4a17fc display MIDI qtr msgs in the MIDI tracer window 2020-03-27 12:37:44 -06:00
Robin Gareus
e219a6cd1e
Source-tree consistency (headless tools at top-level)
This move ardour-lua session tool to top-level, next to
headless/hardev.
2020-03-26 19:00:41 +01:00
nia
7e15496d5a NetBSD has /etc/login.conf too. 2020-03-26 09:39:44 -06:00
Paul Davis
8a65c1fce2 remove visibility of "draggable playhead" option 2020-03-26 07:50:32 -06:00
Paul Davis
d7500056fc stop transport clocks from jumping after the playhead is moved via a CursorDrag 2020-03-25 19:24:38 -06:00
Paul Davis
6291433e27 set Editor::_pending_locate_request to true before sending locate request. 2020-03-25 18:39:59 -06:00
Paul Davis
25c0bd9274 Prevent updates to the playhead when a locate is pending after a drag/click is used to move the playhead.
There are two problem cases:

  1) the drag "fake-located" the playhead, but a redraw happens before the locate itself finishes.
  2) the transport emits Session::PositionChanged from Session::non_realtime_stop(), even though
     this is occuring in the "middle" of the locate process (we stop first).

In the first case, the drag code sets _pending_locate_request, since we need this to be true even
before the queued SessionEvent for the locate has been processed. So to deal with this case

In the second case, we use Session::locate_initiated() to decide if we're in the middle of a locate.
2020-03-25 18:39:59 -06:00
Paul Davis
51165aec0b remove some additional debug output 2020-03-25 16:14:25 -06:00
Paul Davis
0622d69196 change text for a couple of UI config options 2020-03-25 16:10:27 -06:00
Paul Davis
5d1b75bd4f likely fix for cases where a button release event falls through from the canvas to the editor, during a drag
The drag code expects coordinates in canvas coordinates, but we were not translating them at the editor level (canvas event handling
does do this, but cannot affect the situation if the event falls through to the editor)
2020-03-25 15:30:52 -06:00
Paul Davis
4151ec1907 remove accumulated debug output 2020-03-25 15:12:30 -06:00
Robin Gareus
a0f2ae4833
Do not allow aux sends from the master-bus
This always leads to feedback situations. It may be acceptable
via the "allow feedback" option and accepting 1 cycle delay.
yet Aux-sends from the master bus are just bad practice,
and no found on any mixing desk.
2020-03-25 21:38:44 +01:00
Robin Gareus
53c666f1b8
Add restrictions for aux send cut/copy/paste & DnD
This prevents adding duplicate sends via copy/paste, or
creating invalid aux-send in the destination bus.
2020-03-25 21:38:44 +01:00
Robin Gareus
4a24cc5083
Fix Aux-Send names on copy/paste
Sends do not have any ports, so a unique name is not required.
Since 82541b33a4 custom aux names are kept when setting state.

Previously this "worked" because set_state() change the name
of the new aux-send to the name of the target-bus.
2020-03-25 21:38:44 +01:00
Paul Davis
dbcd78cf71 more playhead-drag/click locate debugging 2020-03-25 13:18:58 -06:00
Paul Davis
1b05ebbafa more playhead-drag/click locate debugging 2020-03-25 12:33:46 -06:00
Paul Davis
77ab1a39b8 more playhead-drag/click locate debugging 2020-03-25 11:48:53 -06:00
Paul Davis
becfad91c2 more playhead-drag/click locate debugging 2020-03-25 11:48:18 -06:00
Paul Davis
f8b16e9e83 remove a few cerr outputs and change a couple to use cout, since they are not errors 2020-03-25 11:39:32 -06:00
Paul Davis
04aebc920e more playhead-drag/click locate debugging 2020-03-25 11:23:45 -06:00
Paul Davis
41ff788a76 more playhead-drag/click locate debugging 2020-03-25 11:03:18 -06:00
Paul Davis
4b40243f2b fix two poorly-formed uses of Glib::DateTime 2020-03-25 10:45:00 -06:00
Paul Davis
447a045828 do not parse debug options in a non-debug build 2020-03-25 10:34:16 -06:00
Paul Davis
b3cbd8f44e if user chooses not to delete a scratch session, removed the file that identifies it as unnamed (GUI) 2020-03-25 10:25:00 -06:00
Robin Gareus
ec345037b0
Suppress debug output in optimized builds 2020-03-25 16:43:24 +01:00
Robin Gareus
89904468b3
Fix generic UI crash when plugin has ctrl outputs -- #7937
build_control_ui() special cases `AutomationControl mcontrol = NULL`
to create read-only output display. So Iterating over
Evoral::Control that are not AutomationControl must not crash.

This fixes a bug introduced in a44fecb740.
"Edit with generic controls" caused crashes for plugins with ctrl outs.
2020-03-25 16:36:54 +01:00
Paul Davis
807915b40c remove debug output 2020-03-24 21:15:57 -06:00
Paul Davis
900bab7271 basic pass at deleting scratch sessions 2020-03-24 21:15:32 -06:00
Robin Gareus
4d9017a1fb
Also allow scratch sessions via Session > New 2020-03-25 02:43:20 +01:00
Robin Gareus
993cba5a7c
NO-OP: whitespace 2020-03-25 02:34:17 +01:00
Robin Gareus
e3e794f3a8
Fix crash at exit when closing session before quit 2020-03-25 02:23:16 +01:00
Paul Davis
777ac65831 debug output 2020-03-24 18:55:16 -06:00
Paul Davis
384ded905d debug output 2020-03-24 18:39:46 -06:00
Paul Davis
4d91637b45 handle scratch session when quitting 2020-03-24 18:26:12 -06:00
Nil Geisweiller
fe6c5f98b2
Remove redundant AZERTY Virtual MIDI Keyboard Layout 2020-03-24 22:36:20 +01:00
Paul Davis
97340a5c89 when saving an unnamed session, rename it (GUI edition)
Note that this is done at the GUI level, might need to double check if there are
other paths into a "save" that should be covered. Control surfaces use the action, but
Lua comes to mind
2020-03-24 14:10:39 -06:00
Paul Davis
5d4ad01b58 introduce the idea of an "unnamed" session (GUI edition) 2020-03-24 14:10:39 -06:00
Paul Davis
20717b68bf fix startup behavior if answering "No" to "Do you want to open (this existing session)?" 2020-03-24 14:10:39 -06:00
Paul Davis
ccc9042bf2 detect whether or not user edited the name for a new session
Suprisingly hard/irritating. Thanks, GTK! (Gtk::Entry::set_text() emits all
the same signals that actual user interaction can trigger, except for key events)
2020-03-24 14:10:39 -06:00
Paul Davis
78cf1ed119 prefill new session name with a date-based default
Select it, so that typing will immediately replace it
2020-03-24 14:10:39 -06:00
Robin Gareus
6ddeaa273a
Do not use openGL backed canvas + widgets on Catalina
This needs testing: local builds on Catalina vs.
running existing (10.6, 10.11) builds on 10.15.
2020-03-24 14:27:36 +01:00
Robin Gareus
853bf6d178
Add API to query OSX/MacOS version 2020-03-24 14:25:22 +01:00
Paul Davis
0f63b82943 fix error in multiple calls to SourceFactory::createWritable()
removal of tape tracks removed an intermediate argument in the argument list; presence of default args for the
last two arguments and implicit conversion from int->bool prevented the compiler from complaining
about any existing calls.

This supplements/extends a54b000a70
2020-03-23 21:47:13 -06:00
Paul Davis
3bbad66a99 control over transport-masters-just-roll-when-sync-is-lost 2020-03-23 19:08:57 -06:00
Paul Davis
e04f0a4c2c tweaks to display in TransportMastersWidget to reduce width jumping 2020-03-23 18:34:31 -06:00
Ben Loftis
c765079b2f Show Sends button should instigate a Spill, akin to a VCA spill 2020-03-23 15:24:08 -05:00
Ben Loftis
7058a8074f Theme-ing: Replace lost color for aux-send-panners 2020-03-23 15:24:00 -05:00
Robin Gareus
42cc09af13
Remove Mixbus Aux-Link special case 2/2 2020-03-23 17:45:55 +01:00
Robin Gareus
b760d541c6
Pan: remove automation-state indirection 1/2 2020-03-23 16:41:13 +01:00