smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-10 00:34:59 +01:00
Code Issues Projects Releases Wiki Activity

fix thinko in handling of cue page context menus

Browse source 
Context menus should (unless there is a very strong reason otherwise) be
popped up on button press, not button release. In addition Gtk::Menu::popup()
should be given the button ID of the button used, so that it can manage
both styles of menu interaction (press/drag/release and press/release/drag/press)
This commit is contained in:
Paul Davis 2025-04-28 14:26:15 -06:00
parent 975b01060a
commit fece4f0ca8
6 changed files with 84 additions and 94 deletions
Download patch file Download diff file Expand all files Collapse all files

5
gtk2_ardour/trigger_ui.cc
View file

@ -411,8 +411,7 @@ TriggerUI::context_menu ()
items.push_back (MenuElem (_("MIDI Learn"), sigc::mem_fun (*this, &TriggerUI::trigger_midi_learn)));
items.push_back (MenuElem (_("MIDI un-Learn"), sigc::mem_fun (*this, &TriggerUI::trigger_midi_unlearn)));
_context_menu->popup (3, gtk_get_current_event_time ());
_context_menu->popup (1, gtk_get_current_event_time ());
}
void
@ -547,7 +546,7 @@ TriggerUI::launch_context_menu ()
dynamic_cast<Gtk::CheckMenuItem*> (&items.back ())->set_active (true);
}
_launch_context_menu->popup (3, gtk_get_current_event_time ());
_launch_context_menu->popup (1, gtk_get_current_event_time ());
}
void