smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2026-01-03 04:09:29 +01:00
Code Issues Projects Releases Wiki Activity

libardour: change implementation of MidiModel::insert_silence_at_start()

Browse source 
Use the much lighter weight ShiftCommand model introduced in 4ee709af7b.
This commit is contained in:
Paul Davis 2025-04-08 15:44:05 -06:00
parent 8c49330cfb
commit fe3aadb1bc
2 changed files with 7 additions and 49 deletions
Download patch file Download diff file Expand all files Collapse all files

2
libs/ardour/ardour/midi_model.h
View file

@ -340,7 +340,7 @@ public:
std::shared_ptr<Evoral::Control> control_factory(const Evoral::Parameter& id);
void insert_silence_at_start (TimeType);
void insert_silence_at_start (TimeType, PBD::HistoryOwner&);
void transpose (NoteDiffCommand *, const NotePtr, int);
void track_state (timepos_t const & when, MidiStateTracker&) const;

54
libs/ardour/midi_model.cc
View file

@ -1763,55 +1763,13 @@ MidiModel::control_factory (Evoral::Parameter const & p)
* Adds commands to the session's current undo stack to reflect the movements.
*/
void
MidiModel::insert_silence_at_start (TimeType t)
MidiModel::insert_silence_at_start (TimeType t, HistoryOwner& history)
{
/* Notes */
if (!notes().empty ()) {
NoteDiffCommand* c = new_note_diff_command ("insert silence");
for (Notes::const_iterator i = notes().begin(); i != notes().end(); ++i) {
c->change (*i, NoteDiffCommand::StartTime, (*i)->time() + t);
}
apply_diff_command_as_subcommand (_midi_source.session(), c);
}
/* Patch changes */
if (!patch_changes().empty ()) {
PatchChangeDiffCommand* c = new_patch_change_diff_command ("insert silence");
for (PatchChanges::const_iterator i = patch_changes().begin(); i != patch_changes().end(); ++i) {
c->change_time (*i, (*i)->time() + t);
}
apply_diff_command_as_subcommand (_midi_source.session(), c);
}
/* Controllers */
for (Controls::iterator i = controls().begin(); i != controls().end(); ++i) {
std::shared_ptr<AutomationControl> ac = std::dynamic_pointer_cast<AutomationControl> (i->second);
XMLNode& before = ac->alist()->get_state ();
i->second->list()->shift (timepos_t::zero (i->second->list()->time_domain()), timecnt_t (t));
XMLNode& after = ac->alist()->get_state ();
_midi_source.session().add_command (new MementoCommand<AutomationList> (new MidiAutomationListBinder (_midi_source, i->first), &before, &after));
}
/* Sys-ex */
if (!sysexes().empty()) {
SysExDiffCommand* c = new_sysex_diff_command ("insert silence");
for (SysExes::iterator i = sysexes().begin(); i != sysexes().end(); ++i) {
c->change (*i, (*i)->time() + t);
}
apply_diff_command_as_subcommand (_midi_source.session(), c);
}
ContentsShifted (timecnt_t (t));
/* go via the MidiSource to get a shared_ptr to
* ourselves. Probably faster than shared_from_this()
*/
apply_diff_command_as_subcommand (history, new MidiModel::ShiftCommand (_midi_source.model(), std::string(), t));
ContentsShifted (timecnt_t (t)); /* EMIT SIGNAL */
}
void