From f74acc6e7921e82842b1c33eb7da00204c6f3039 Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Mon, 30 Mar 2015 19:52:21 +0200 Subject: [PATCH] note to midi devs. --- libs/ardour/midi_ring_buffer.cc | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/libs/ardour/midi_ring_buffer.cc b/libs/ardour/midi_ring_buffer.cc index c2e040d947..7e88f5ff45 100644 --- a/libs/ardour/midi_ring_buffer.cc +++ b/libs/ardour/midi_ring_buffer.cc @@ -165,6 +165,18 @@ MidiRingBuffer::skip_to(framepos_t start) ++count; + /* TODO investigate and think: + * + * Does it makes sense to keep track of notes + * that are skipped (because they're either too late + * (underrun) or never used (read-ahead, loop) ? + * + * skip_to() is called on the rinbuffer between + * disk and process. it seems wrong to track them + * (a potential synth never sees skipped notes, either) + * but there may be more to this. + */ + if (ev_size >= 8) { this->increment_read_ptr (ev_size); } else {