From f491d7ec71b4dc9b4d94be228dd8067c67f5e5f3 Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Thu, 5 Sep 2019 00:40:48 +0200 Subject: [PATCH] Use Fixed-length when drawing percussive events Previously adding percussive-hits created sustained notes using the current grid as duration. This allowed to create overlapping notes with the overlap not being visible. Most hardware MIDI drumkits do send an immediate note-off event after each hit (if they send note-offs at all). Ardour now follows suit and does the same when using the draw/edit tool. --- gtk2_ardour/editor_drag.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtk2_ardour/editor_drag.cc b/gtk2_ardour/editor_drag.cc index 87d74b65c9..ad3f8478e9 100644 --- a/gtk2_ardour/editor_drag.cc +++ b/gtk2_ardour/editor_drag.cc @@ -6818,7 +6818,7 @@ HitCreateDrag::start_grab (GdkEvent* event, Gdk::Cursor* cursor) } const samplepos_t start = map.sample_at_quarter_note (eqaf) - _region_view->region()->position(); - Temporal::Beats length = _region_view->get_grid_beats (pf); + Temporal::Beats length = Temporal::Beats(1.0 / 32.0); /* 1/32 beat = 1/128 note */ _editor->begin_reversible_command (_("Create Hit")); _region_view->clear_editor_note_selection();