From f29e5ea7ab5a3df0179b285263682f03c5dfcf7c Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Thu, 13 Feb 2020 22:24:24 +0100 Subject: [PATCH] Leave processor box sensitive when editing aux-sends This is required to toggle the strip to revert from aux-view to the main route using the aux-send processor itself. Discuss: Perhaps this should be reverted, and ProcessorBox::edit_aux_send() be removed: It is currently possible to create various inconsistent mixer-states. * use "Aux" on a Bus, then double-click some Internal-Send to revert strips. But Aux remains active * Removing sends while "Aux" is active does not disable Aux. If the processor box was insensitive those issues won't be present. However it is convenient to use double-click on the editor-mixer to access a send's panner ... --- gtk2_ardour/mixer_strip.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/gtk2_ardour/mixer_strip.cc b/gtk2_ardour/mixer_strip.cc index f39fc4d8c3..91bc5c45c7 100644 --- a/gtk2_ardour/mixer_strip.cc +++ b/gtk2_ardour/mixer_strip.cc @@ -1966,7 +1966,6 @@ MixerStrip::map_frozen () boost::shared_ptr at = audio_track(); bool en = _route->active () || ARDOUR::Profile->get_mixbus(); - bool send = _current_delivery && boost::dynamic_pointer_cast(_current_delivery) != 0; if (at) { switch (at->freeze_state()) { @@ -1975,11 +1974,11 @@ MixerStrip::map_frozen () hide_redirect_editors (); break; default: - processor_box.set_sensitive (en && !send); + processor_box.set_sensitive (en); break; } } else { - processor_box.set_sensitive (en && !send); + processor_box.set_sensitive (en); } RouteUI::map_frozen (); }