smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-06 14:54:56 +01:00
Code Issues Projects Releases Wiki Activity

avoid unintended note highlighting in MIDI pianoroll header

Browse source
This commit is contained in:
Paul Davis 2025-11-02 14:24:52 -07:00
parent 876ed98dbe
commit f12c328b63
1 changed files with 20 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

24
gtk2_ardour/prh_base.cc
View file

@ -133,6 +133,7 @@ bool
PianoRollHeaderBase::scroll_handler (GdkEventScroll* ev) PianoRollHeaderBase::scroll_handler (GdkEventScroll* ev)
{ {
double evy = ev->y; double evy = ev->y;
bool in_scroomer = ev->x < _scroomer_size;
int note_range = _adj.get_page_size (); int note_range = _adj.get_page_size ();
int note_lower = _adj.get_value (); int note_lower = _adj.get_value ();
@ -161,7 +162,9 @@ PianoRollHeaderBase::scroll_handler (GdkEventScroll* ev)
} }
} }
set_note_highlight (_midi_context.y_to_note (event_y_to_y (evy))); if (!in_scroomer) {
set_note_highlight (_midi_context.y_to_note (event_y_to_y (evy)));
}
_adj.value_changed (); _adj.value_changed ();
redraw (); redraw ();
@ -521,8 +524,9 @@ PianoRollHeaderBase::motion_handler (GdkEventMotion* ev)
/* event coordinates are in canvas/window space */ /* event coordinates are in canvas/window space */
double evy = ev->y; double evy = ev->y;
bool in_scroomer = ev->x < _scroomer_size;
if (!_scroomer_drag && ev->x < _scroomer_size){ if (!_scroomer_drag && in_scroomer) {
double scroomer_top = max (1.0, (1.0 - ((_adj.get_value()+_adj.get_page_size()) / 127.0)) * height()); double scroomer_top = max (1.0, (1.0 - ((_adj.get_value()+_adj.get_page_size()) / 127.0)) * height());
double scroomer_bottom = (1.0 - (_adj.get_value () / 127.0)) * height(); double scroomer_bottom = (1.0 - (_adj.get_value () / 127.0)) * height();
@ -612,7 +616,15 @@ PianoRollHeaderBase::motion_handler (GdkEventMotion* ev)
} else { } else {
int note = _midi_context.y_to_note(evy); int note = _midi_context.y_to_note(evy);
set_note_highlight (note);
if (!in_scroomer) {
set_note_highlight (note);
} else {
if (_highlighted_note != NO_MIDI_NOTE) {
invalidate_note_range (_highlighted_note, _highlighted_note);
_highlighted_note = NO_MIDI_NOTE;
}
}
if (_dragging) { if (_dragging) {
@ -788,8 +800,12 @@ bool
PianoRollHeaderBase::enter_handler (GdkEventCrossing* ev) PianoRollHeaderBase::enter_handler (GdkEventCrossing* ev)
{ {
double evy = ev->y; double evy = ev->y;
bool in_scroomer = ev->x < _scroomer_size;
if (!in_scroomer) {
set_note_highlight (_midi_context.y_to_note (evy));
}
set_note_highlight (_midi_context.y_to_note (evy));
set_cursor (_midi_context.editing_context().cursors()->selector); set_cursor (_midi_context.editing_context().cursors()->selector);
entered = true; entered = true;
redraw (); redraw ();