From ef07fb601a91b25c031e10c943873b3448a4b975 Mon Sep 17 00:00:00 2001 From: Paul Davis Date: Sun, 29 May 2022 14:19:02 -0600 Subject: [PATCH] libcanvas: FramedCanvas::covers() method is ill-conceived. Use PolyItem::covers() --- libs/canvas/canvas/framed_curve.h | 1 - libs/canvas/framed_curve.cc | 21 --------------------- 2 files changed, 22 deletions(-) diff --git a/libs/canvas/canvas/framed_curve.h b/libs/canvas/canvas/framed_curve.h index 2bb18ad961..42d1da690a 100644 --- a/libs/canvas/canvas/framed_curve.h +++ b/libs/canvas/canvas/framed_curve.h @@ -49,7 +49,6 @@ class LIBCANVAS_API FramedCurve : public PolyItem, public InterpolatedCurve void set_points_per_segment (uint32_t n); - bool covers (Duple const &) const; void set_fill_mode (CurveFill cf) { curve_fill = cf; } private: diff --git a/libs/canvas/framed_curve.cc b/libs/canvas/framed_curve.cc index 966792a025..cc6334ac72 100644 --- a/libs/canvas/framed_curve.cc +++ b/libs/canvas/framed_curve.cc @@ -289,24 +289,3 @@ FramedCurve::render (Rect const & area, Cairo::RefPtr context) c #endif } -bool -FramedCurve::covers (Duple const & pc) const -{ - Duple point = window_to_item (pc); - - /* O(N) N = number of points, and not accurate */ - - for (Points::const_iterator p = _points.begin(); p != _points.end(); ++p) { - - const Coord dx = point.x - (*p).x; - const Coord dy = point.y - (*p).y; - const Coord dx2 = dx * dx; - const Coord dy2 = dy * dy; - - if ((dx2 < 2.0 && dy2 < 2.0) || (dx2 + dy2 < 4.0)) { - return true; - } - } - - return false; -}