smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-06 23:05:04 +01:00
Code Issues Projects Releases Wiki Activity

interface range generated by internal_to_interface() may not span 0..1, so remove asserts

Browse source
This commit is contained in:
Paul Davis 2019-10-11 17:09:39 -06:00
parent 5163393c11
commit e6901dca30
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
gtk2_ardour/automation_controller.cc
View file

@ -147,16 +147,16 @@ AutomationController::create(const Evoral::Parameter& param,
bool use_knob) bool use_knob)
{ {
const double lo = ac->internal_to_interface(desc.lower, true); const double lo = ac->internal_to_interface(desc.lower, true);
const double up = ac->internal_to_interface(desc.upper, true);
const double normal = ac->internal_to_interface(desc.normal, true); const double normal = ac->internal_to_interface(desc.normal, true);
const double smallstep = fabs (ac->internal_to_interface(desc.lower + desc.smallstep, true) - lo); const double smallstep = fabs (ac->internal_to_interface(desc.lower + desc.smallstep, true) - lo);
const double largestep = fabs (ac->internal_to_interface(desc.lower + desc.largestep, true) - lo); const double largestep = fabs (ac->internal_to_interface(desc.lower + desc.largestep, true) - lo);
assert (std::min(lo, up) == 0); /* even though internal_to_interface() may not generate the full range
assert (std::max(lo, up) == 1.0); * 0..1, the interface range is 0..1 by definition, so just hard code
* that.
*/
Gtk::Adjustment* adjustment = manage ( Gtk::Adjustment* adjustment = manage (new Gtk::Adjustment (normal, 0.0, 1.0, smallstep, largestep));
new Gtk::Adjustment (normal, std::min(lo, up), std::max(lo, up), smallstep, largestep));
assert (ac); assert (ac);
assert(ac->parameter() == param); assert(ac->parameter() == param);