smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-17 12:16:30 +01:00
Code Issues Projects Releases Wiki Activity

Fix possible race (BaseUI creation vs x-thread signal-emission)

Browse source 
When a BaseUI is being created, signals can arrive before the
_run_loop_thread is running, which can trigger an assert in
BaseUI::caller_is_self().
This commit is contained in:
Robin Gareus 2022-03-01 17:18:14 +01:00
parent 638af32902
commit e417495505
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
libs/pbd/base_ui.cc
View file

@ -119,11 +119,12 @@ BaseUI::run ()
m_context = MainContext::create(); m_context = MainContext::create();
_main_loop = MainLoop::create (m_context); _main_loop = MainLoop::create (m_context);
attach_request_source ();
Glib::Threads::Mutex::Lock lm (_run_lock); Glib::Threads::Mutex::Lock lm (_run_lock);
_run_loop_thread = PBD::Thread::create (boost::bind (&BaseUI::main_thread, this)); _run_loop_thread = PBD::Thread::create (boost::bind (&BaseUI::main_thread, this));
_running.wait (_run_lock); _running.wait (_run_lock);
attach_request_source ();
} }
void void