smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-17 20:26:30 +01:00
Code Issues Projects Releases Wiki Activity

after cloning a MIDI region, mark the source file as non-removable. Fixes reports about missing MIDI files on the forums and IRC

Browse source
This commit is contained in:
Paul Davis 2014-04-04 15:26:44 -04:00
parent 99bf5d9eed
commit e1bf151ab0
4 changed files with 20 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
libs/ardour/ardour/file_source.h
View file

@ -82,6 +82,8 @@ public:
static PBD::Signal3<int,std::string,std::string,std::vector<std::string> > AmbiguousFileName; static PBD::Signal3<int,std::string,std::string,std::vector<std::string> > AmbiguousFileName;
virtual void prevent_deletion ();
protected: protected:
FileSource (Session& session, DataType type, FileSource (Session& session, DataType type,
const std::string& path, const std::string& path,
@ -103,7 +105,6 @@ protected:
std::string _origin; std::string _origin;
bool _open; bool _open;
void prevent_deletion ();
}; };
} // namespace ARDOUR } // namespace ARDOUR

2
libs/ardour/ardour/smf_source.h
View file

@ -69,6 +69,8 @@ public:
static bool safe_midi_file_extension (const std::string& path); static bool safe_midi_file_extension (const std::string& path);
void prevent_deletion ();
protected: protected:
void set_path (const std::string& newpath); void set_path (const std::string& newpath);

5
libs/ardour/midi_source.cc
View file

@ -39,6 +39,7 @@
#include "ardour/midi_model.h" #include "ardour/midi_model.h"
#include "ardour/midi_state_tracker.h" #include "ardour/midi_state_tracker.h"
#include "ardour/midi_source.h" #include "ardour/midi_source.h"
#include "ardour/file_source.h"
#include "ardour/session.h" #include "ardour/session.h"
#include "ardour/session_directory.h" #include "ardour/session_directory.h"
#include "ardour/source_factory.h" #include "ardour/source_factory.h"
@ -382,6 +383,10 @@ MidiSource::clone (const string& path, Evoral::MusicalTime begin, Evoral::Musica
newsrc->set_model (_model); newsrc->set_model (_model);
} }
/* this file is not removable (but since it is MIDI, it is mutable) */
boost::dynamic_pointer_cast<FileSource> (newsrc)->prevent_deletion ();
return newsrc; return newsrc;
} }

12
libs/ardour/smf_source.cc
View file

@ -72,9 +72,10 @@ SMFSource::SMFSource (Session& s, const string& path, Source::Flag flags)
return; return;
} }
if (open(_path)) { if (open (_path)) {
throw failed_constructor (); throw failed_constructor ();
} }
_open = true; _open = true;
} }
@ -657,3 +658,12 @@ SMFSource::ensure_disk_file ()
} }
} }
void
SMFSource::prevent_deletion ()
{
/* Unlike the audio case, the MIDI file remains mutable (because we can
edit MIDI data)
*/
_flags = Flag (_flags & ~(Removable|RemovableIfEmpty|RemoveAtDestroy));
}