smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2026-01-01 11:27:45 +01:00
Code Issues Projects Releases Wiki Activity

Engine Dialog: fix memory-leak, do not manage Labels

Browse source 
Gtk::manage only destroys managed widgets when the parent container
is destroyed. In Ardour's case this is not the case since
Gtkmm2ext::container_clear() is used to unpack/repack widgets
as required.
This commit is contained in:
Robin Gareus 2022-07-01 23:54:44 +02:00
parent 8f4aab9584
commit ddca042b7b
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
2 changed files with 65 additions and 57 deletions
Download patch file Download diff file Expand all files Collapse all files

19
gtk2_ardour/engine_dialog.h
View file

@ -77,7 +77,6 @@ private:
Gtk::ComboBoxText sample_rate_combo;
Gtk::ComboBoxText midi_option_combo;
Gtk::ComboBoxText buffer_size_combo;
Gtk::Label buffer_size_duration_label;
Gtk::ComboBoxText nperiods_combo;
Gtk::Adjustment input_latency_adjustment;
Gtk::SpinButton input_latency;
@ -85,7 +84,23 @@ private:
Gtk::SpinButton output_latency;
Gtk::ComboBoxText monitor_model_combo;
Gtk::Label have_control_text;
Gtk::Label lbl_audio_system;
Gtk::Label lbl_midi_system;
Gtk::Label lbl_driver;
Gtk::Label lbl_device;
Gtk::Label lbl_input_device;
Gtk::Label lbl_output_device;
Gtk::Label lbl_sample_rate;
Gtk::Label lbl_buffer_size;
Gtk::Label lbl_nperiods;
Gtk::Label lbl_input_latency;
Gtk::Label lbl_output_latency;
Gtk::Label lbl_monitor_model;
Gtk::Label lbl_jack_msg;
Gtk::Label unit_samples_text;
Gtk::Label buffer_size_duration_label;
Gtk::Label have_control_text;
ArdourWidgets::ArdourButton control_app_button;
ArdourWidgets::ArdourButton midi_devices_button;
ArdourWidgets::ArdourButton start_stop_button;