smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2026-01-06 21:55:43 +01:00
Code Issues Projects Releases Wiki Activity

FileSource should not generate its own error message when a file is missing

Browse source
This commit is contained in:
Paul Davis 2014-09-15 12:38:16 -04:00
parent 65f51e9884
commit d2bafa896c
1 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
libs/ardour/file_source.cc
View file

@ -252,8 +252,6 @@ FileSource::find (Session& s, DataType type, const string& path, bool must_exist
goto out;
}
hits.clear ();
for (vector<string>::iterator i = dirs.begin(); i != dirs.end(); ++i) {
fullpath = Glib::build_filename (*i, path);
@ -308,8 +306,9 @@ FileSource::find (Session& s, DataType type, const string& path, bool must_exist
/* no match: error */
if (must_exist) {
error << string_compose(
_("Filesource: cannot find required file (%1)"), path) << endmsg;
/* do not generate an error here, leave that to
whoever deals with the false return value.
*/
goto out;
} else {
isnew = true;
@ -320,16 +319,17 @@ FileSource::find (Session& s, DataType type, const string& path, bool must_exist
keeppath = de_duped_hits[0];
}
} else {
} else {
keeppath = path;
}
/* Current find() is unable to parse relative path names to yet non-existant
sources. QuickFix(tm)
*/
if (keeppath == "") {
if (must_exist) {
if (keeppath.empty()) {
if (must_exist) {
error << "FileSource::find(), keeppath = \"\", but the file must exist" << endl;
} else {
keeppath = path;