smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2026-01-01 19:37:45 +01:00
Code Issues Projects Releases Wiki Activity

Fix crash when repeatedly showing group menu

Browse source 
route_group_menu needs to be detached before
TimeAxisView::build_display_menu () deletes and recreates
the parent menu.
This commit is contained in:
Robin Gareus 2025-12-18 03:37:59 +01:00
parent fbc4bc4437
commit d23bcd1685
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
gtk2_ardour/route_group_menu.cc
View file

@ -47,6 +47,7 @@ RouteGroupMenu::RouteGroupMenu (Session* s, PropertyList* plist)
RouteGroupMenu::~RouteGroupMenu()
{
detach ();
delete _menu;
delete _default_properties;
}

5
gtk2_ardour/route_time_axis.cc
View file

@ -627,6 +627,10 @@ RouteTimeAxisView::build_display_menu ()
detach_menu (*automation_action_menu);
}
if (route_group_menu) {
route_group_menu->detach ();
}
TimeAxisView::build_display_menu ();
bool active = _route->active ();
@ -812,7 +816,6 @@ RouteTimeAxisView::build_display_menu ()
}
if (!_route->is_singleton ()) {
route_group_menu->detach ();
route_group_menu->build (r);
items.push_back (MenuElem (_("Group"), *route_group_menu->menu ()));
}