From cc4aeb1f40c763bb449df3ff3b8fb897f46bc4aa Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Wed, 12 Feb 2020 17:04:44 +0100 Subject: [PATCH] Prevent out-of-bounds array access --- libs/ardour/disk_reader.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libs/ardour/disk_reader.cc b/libs/ardour/disk_reader.cc index 99fefd7959..bc49afb932 100644 --- a/libs/ardour/disk_reader.cc +++ b/libs/ardour/disk_reader.cc @@ -1513,13 +1513,13 @@ DiskReader::Declicker::alloc (samplecnt_t sr, bool fadein) if (fadein) { gain_t g = 0.0; - for (n = 0; (n < sr) && ((1.0 - g) > GAIN_COEFF_DELTA); ++n) { + for (n = 0; (n < loop_fade_length) && ((1.f - g) > GAIN_COEFF_DELTA); ++n) { vec[n] = g; g += a * (1.0 - g); } } else { gain_t g = 1.0; - for (n = 0; (n < sr) && (g > GAIN_COEFF_DELTA); ++n) { + for (n = 0; (n < loop_fade_length) && (g > GAIN_COEFF_DELTA); ++n) { vec[n] = g; g += a * -g; }