smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-06 14:54:56 +01:00
Code Issues Projects Releases Wiki Activity

MIDI region extend-selection should select all after start of selection, not all after end of selection

Browse source
This commit is contained in:
Paul Davis 2021-06-08 08:31:41 -06:00
parent 11cb981e30
commit c46410a1b0
1 changed files with 11 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

16
gtk2_ardour/midi_region_view.cc
View file

@ -2195,18 +2195,24 @@ MidiRegionView::extend_selection ()
/* find end of current selection */ /* find end of current selection */
samplepos_t last_note_end = 0; /* XXX NUTEMPO WARNING */
samplepos_t first_note_start = max_samplepos;
for (Selection::iterator i = _selection.begin(); i != _selection.end(); ++i) { for (Selection::iterator i = _selection.begin(); i != _selection.end(); ++i) {
samplepos_t e = source_beats_to_absolute_samples ((*i)->note()->end_time()); samplepos_t e = source_beats_to_absolute_samples ((*i)->note()->time());
if (e > last_note_end) { if (e < first_note_start) {
last_note_end = e; first_note_start = e;
} }
} }
for (Events::iterator i = _events.begin(); i != _events.end(); ++i) { for (Events::iterator i = _events.begin(); i != _events.end(); ++i) {
samplepos_t t = source_beats_to_absolute_samples(i->first->time()); samplepos_t t = source_beats_to_absolute_samples(i->first->time());
if (t >= last_note_end) {
if (i->second->selected()) {
continue;
}
if (t >= first_note_start) {
add_to_selection (i->second); add_to_selection (i->second);
} }
} }