smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2026-01-09 15:15:41 +01:00
Code Issues Projects Releases Wiki Activity

Fix erasing events in MIDIBuffer

Browse source 
When the last event in a MIDI buffer was erased, the whole buffer
was assumed to be empty (bug introduced in 7.5-96-gc5511040ec)
This commit is contained in:
Robin Gareus 2023-12-15 08:50:10 +01:00
parent 066df7cc1a
commit c3b55240b1
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
libs/ardour/ardour/midi_buffer.h
View file

@ -153,12 +153,18 @@ public:
size_t total_data_deleted = align32 (sizeof(TimeType) + sizeof (Evoral::EventType) + event_size);
if (i.offset + total_data_deleted >= _size) {
if (total_data_deleted >= _size) {
_size = 0;
_silent = true;
return end();
}
if (i.offset + total_data_deleted >= _size) {
assert (_size > total_data_deleted);
_size -= total_data_deleted;
return end();
}
/* we need to avoid the temporary malloc that memmove would do,
so copy by hand. remember: this is small amounts of data ...
*/