smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-10 00:34:59 +01:00
Code Issues Projects Releases Wiki Activity

Consistently use context-menu button action

Browse source 
This fixes an issue where brining up a menu can directly activate an
action in the menu. Notably on macOS.

Nathan reports that this may also address #9515

Note: mac touchpads are not affected since right-click there is
effectively a "press and hold".
This commit is contained in:
Robin Gareus 2023-10-31 20:10:49 +01:00
parent 43c5f0ab46
commit c162aa7aca
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
22 changed files with 39 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

10
gtk2_ardour/route_ui.cc
View file

@ -487,7 +487,7 @@ RouteUI::mute_press (GdkEventButton* ev)
build_mute_menu();
}
mute_menu->popup(0,ev->time);
mute_menu->popup (ev->button, ev->time);
return true;
@ -653,7 +653,7 @@ RouteUI::solo_press(GdkEventButton* ev)
build_solo_menu ();
}
solo_menu->popup (1, ev->time);
solo_menu->popup (ev->button, ev->time);
} else {
@ -1027,7 +1027,7 @@ RouteUI::rec_enable_release (GdkEventButton* ev)
if (Keyboard::is_context_menu_event (ev)) {
build_record_menu ();
if (_record_menu) {
_record_menu->popup (1, ev->time);
_record_menu->popup (ev->button, ev->time);
}
return false;
}
@ -1154,7 +1154,7 @@ RouteUI::show_sends_press(GdkEventButton* ev)
build_sends_menu ();
}
sends_menu->popup (0, ev->time);
sends_menu->popup (ev->button, ev->time);
} else if (ev->button == 1) {
@ -2233,7 +2233,7 @@ RouteUI::invert_press (GdkEventButton* ev)
--_i_am_the_modifier;
}
_invert_menu->popup (0, ev->time);
_invert_menu->popup (ev->button, ev->time);
return true;
}