smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-06 06:44:57 +01:00
Code Issues Projects Releases Wiki Activity

Fix switch custom -> generic plugin UI (amend e635571f2f)

Browse source
This commit is contained in:
Robin Gareus 2022-10-11 02:40:26 +02:00
parent 0bf8e7d8cf
commit bd898a68df
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
gtk2_ardour/processor_box.cc
View file

@ -4684,7 +4684,7 @@ ProcessorWindowProxy::ProcessorWindowProxy (string const & name, ProcessorBox* b
boost::shared_ptr<PluginInsert> pi = boost::dynamic_pointer_cast<PluginInsert> (p); boost::shared_ptr<PluginInsert> pi = boost::dynamic_pointer_cast<PluginInsert> (p);
if (pi) { if (pi) {
signal_unmap.connect (sigc::bind ([] (ProxyBase* self, PluginType type) { _unmap_connection = signal_unmap.connect (sigc::bind ([] (ProxyBase* self, PluginType type) {
ProcessorWindowProxy* me = dynamic_cast<ProcessorWindowProxy*> (self); ProcessorWindowProxy* me = dynamic_cast<ProcessorWindowProxy*> (self);
if (!me->is_custom) { if (!me->is_custom) {
return; return;
@ -4796,6 +4796,7 @@ ProcessorWindowProxy::get (bool create)
void void
ProcessorWindowProxy::show_the_right_window (bool show_not_toggle) ProcessorWindowProxy::show_the_right_window (bool show_not_toggle)
{ {
_unmap_connection.disconnect ();
if (_window && (is_custom != want_custom)) { if (_window && (is_custom != want_custom)) {
/* drop existing window - wrong type */ /* drop existing window - wrong type */
set_state_mask (Gtkmm2ext::WindowProxy::StateMask (state_mask () & ~WindowProxy::Size)); set_state_mask (Gtkmm2ext::WindowProxy::StateMask (state_mask () & ~WindowProxy::Size));

1
gtk2_ardour/processor_box.h
View file

@ -112,6 +112,7 @@ private:
bool want_custom; bool want_custom;
void processor_going_away (); void processor_going_away ();
sigc::connection _unmap_connection;
PBD::ScopedConnection going_away_connection; PBD::ScopedConnection going_away_connection;
PBD::ScopedConnectionList gui_connections; PBD::ScopedConnectionList gui_connections;
}; };