smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-15 19:16:40 +01:00
Code Issues Projects Releases Wiki Activity

VST3: GUI d'tor re-order

Browse source 
We have to call close_view(), which calls IPlugView::removed()
before destroying the parent widget.

Previously ~VST3PluginUI() was called after the derived class
destroyed the owned private `_gui_widget`, `_ns_view` or x11 parent.

On windows that may lead to the hwnd of the window becoming invalid
before the call to ::removed().
This commit is contained in:
Robin Gareus 2020-12-14 19:29:53 +01:00
parent 0d4ab880a8
commit bbc54873ae
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
4 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
gtk2_ardour/vst3_plugin_ui.cc
View file

@ -56,8 +56,6 @@ VST3PluginUI::VST3PluginUI (boost::shared_ptr<PluginInsert> pi, boost::shared_pt
VST3PluginUI::~VST3PluginUI ()
{
assert (_view_realized);
_vst3->close_view ();
}
gint