smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-12 09:36:33 +01:00
Code Issues Projects Releases Wiki Activity

CoreMIDI: fix crash when receiving long MIDI messages

Browse source 
CoreMidiIo::recv_event imposes a limit of 1024 bytes/packet.
This commit is contained in:
Robin Gareus 2024-06-04 16:43:20 +02:00
parent 0ec926668c
commit b9bca313d2
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
libs/backends/coreaudio/coremidi_io.h
View file

@ -38,7 +38,7 @@ namespace ARDOUR {
typedef struct _CoreMIDIPacket { typedef struct _CoreMIDIPacket {
MIDITimeStamp timeStamp; MIDITimeStamp timeStamp;
UInt16 length; UInt16 length;
Byte data[256]; Byte data[1024];
#if 0 // unused #if 0 // unused
_CoreMIDIPacket (MIDITimeStamp t, Byte *d, UInt16 l) _CoreMIDIPacket (MIDITimeStamp t, Byte *d, UInt16 l)
: timeStamp(t) : timeStamp(t)
@ -56,6 +56,7 @@ typedef struct _CoreMIDIPacket {
: timeStamp(other->timeStamp) : timeStamp(other->timeStamp)
, length (other->length) , length (other->length)
{ {
assert (l <= 1024);
if (length > 0) { if (length > 0) {
memcpy(data, other->data, length); memcpy(data, other->data, length);
} }