smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-18 04:36:30 +01:00
Code Issues Projects Releases Wiki Activity

fix toggle_roll will only start but not stop PH

Browse source
This commit is contained in:
Len Ovens 2020-08-11 10:09:11 -07:00
parent 365cc92cba
commit b8da1d0265
2 changed files with 11 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
libs/surfaces/osc/osc.cc
View file

@ -494,8 +494,8 @@ OSC::register_callbacks()
REGISTER_CALLBACK (serv, X_("/click/level"), "f", click_level); REGISTER_CALLBACK (serv, X_("/click/level"), "f", click_level);
REGISTER_CALLBACK (serv, X_("/midi_panic"), "", midi_panic); REGISTER_CALLBACK (serv, X_("/midi_panic"), "", midi_panic);
REGISTER_CALLBACK (serv, X_("/midi_panic"), "f", midi_panic); REGISTER_CALLBACK (serv, X_("/midi_panic"), "f", midi_panic);
REGISTER_CALLBACK (serv, X_("/toggle_roll"), "", toggle_roll); REGISTER_CALLBACK (serv, X_("/toggle_roll"), "", osc_toggle_roll);
REGISTER_CALLBACK (serv, X_("/toggle_roll"), "f", toggle_roll); REGISTER_CALLBACK (serv, X_("/toggle_roll"), "f", osc_toggle_roll);
REGISTER_CALLBACK (serv, X_("/stop_forget"), "", stop_forget); REGISTER_CALLBACK (serv, X_("/stop_forget"), "", stop_forget);
REGISTER_CALLBACK (serv, X_("/stop_forget"), "f", stop_forget); REGISTER_CALLBACK (serv, X_("/stop_forget"), "f", stop_forget);
REGISTER_CALLBACK (serv, X_("/set_punch_range"), "", set_punch_range); REGISTER_CALLBACK (serv, X_("/set_punch_range"), "", set_punch_range);
@ -1450,6 +1450,13 @@ OSC::cancel_all_solos ()
return 0; return 0;
} }
int
OSC::osc_toggle_roll ()
{
toggle_roll (false);
return 0;
}
lo_address lo_address
OSC::get_address (lo_message msg) OSC::get_address (lo_message msg)
{ {

3
libs/surfaces/osc/osc.h
View file

@ -438,7 +438,7 @@ class OSC : public ARDOUR::ControlProtocol, public AbstractUI<OSCUIRequest>
PATH_CALLBACK(mark_out); PATH_CALLBACK(mark_out);
PATH_CALLBACK(toggle_click); PATH_CALLBACK(toggle_click);
PATH_CALLBACK(midi_panic); PATH_CALLBACK(midi_panic);
PATH_CALLBACK(toggle_roll); PATH_CALLBACK(osc_toggle_roll);
PATH_CALLBACK(stop_forget); PATH_CALLBACK(stop_forget);
PATH_CALLBACK(set_punch_range); PATH_CALLBACK(set_punch_range);
PATH_CALLBACK(set_loop_range); PATH_CALLBACK(set_loop_range);
@ -822,6 +822,7 @@ class OSC : public ARDOUR::ControlProtocol, public AbstractUI<OSCUIRequest>
void notify_vca_added (ARDOUR::VCAList &); void notify_vca_added (ARDOUR::VCAList &);
int cancel_all_solos (); int cancel_all_solos ();
int osc_toggle_roll ();
bool periodic (void); bool periodic (void);
sigc::connection periodic_connection; sigc::connection periodic_connection;
PBD::ScopedConnectionList session_connections; PBD::ScopedConnectionList session_connections;