From b58c22c1bea6e9d223643a2766f3358fdd4465a1 Mon Sep 17 00:00:00 2001 From: David Robillard Date: Tue, 15 Jun 2021 15:38:42 -0400 Subject: [PATCH] Remove BasicUI default constructor Towards stronger lifetime guarantees, in particular the validity of _session. I was expecting this to be a whole ordeal, but... compiler says no. --- libs/surfaces/control_protocol/basic_ui.cc | 5 ----- libs/surfaces/control_protocol/control_protocol/basic_ui.h | 1 - 2 files changed, 6 deletions(-) diff --git a/libs/surfaces/control_protocol/basic_ui.cc b/libs/surfaces/control_protocol/basic_ui.cc index f394e4d7e3..fe17035db9 100644 --- a/libs/surfaces/control_protocol/basic_ui.cc +++ b/libs/surfaces/control_protocol/basic_ui.cc @@ -48,11 +48,6 @@ BasicUI::BasicUI (Session& s) { } -BasicUI::BasicUI () - : _session (0) -{ -} - BasicUI::~BasicUI () { diff --git a/libs/surfaces/control_protocol/control_protocol/basic_ui.h b/libs/surfaces/control_protocol/control_protocol/basic_ui.h index de70711067..d3785c0b2d 100644 --- a/libs/surfaces/control_protocol/control_protocol/basic_ui.h +++ b/libs/surfaces/control_protocol/control_protocol/basic_ui.h @@ -155,7 +155,6 @@ class LIBCONTROLCP_API BasicUI { bool loop_button_onoff() const; protected: - BasicUI (); ARDOUR::Session* _session; };