From abf92e42c04f7c2fe32d40e871c5e1a9b9775cd9 Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Sun, 27 Nov 2022 03:15:18 +0100 Subject: [PATCH] Do not explicitly copy [whole-file] Region Playlist::add_region copies regions as needed (see 8d045e15dcd), without forking the Source. This fixes an issue when importing MIDI files. When midi-copy-is-fork is enabled (enabled by default), the RegionFactory::create call used during import forked the region. This resulted in two Sources being created for each imported MIDI file. --- gtk2_ardour/editor_audio_import.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gtk2_ardour/editor_audio_import.cc b/gtk2_ardour/editor_audio_import.cc index 5827f64d20..dfa9fdec06 100644 --- a/gtk2_ardour/editor_audio_import.cc +++ b/gtk2_ardour/editor_audio_import.cc @@ -1144,9 +1144,8 @@ Editor::finish_bringing_in_material (boost::shared_ptr region, } } else { boost::shared_ptr playlist = existing_track->playlist(); - boost::shared_ptr copy (RegionFactory::create (region, true)); playlist->clear_changes (); - playlist->add_region (copy, pos); + playlist->add_region (region, pos); _session->add_command (new StatefulDiffCommand (playlist)); } break;