smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-07 15:25:01 +01:00
Code Issues Projects Releases Wiki Activity

Hide colorpicker eyedropper on platforms where it does not work

Browse source
This commit is contained in:
Robin Gareus 2025-11-12 14:56:28 +01:00
parent 224e5ec163
commit a7e557ad65
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
1 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
libs/tk/ytk/gtkcolorsel.c
View file

@ -367,6 +367,17 @@ gtk_color_selection_init (GtkColorSelection *colorsel)
gtk_container_add (GTK_CONTAINER (frame), priv->sample_area); gtk_container_add (GTK_CONTAINER (frame), priv->sample_area);
gtk_box_pack_start (GTK_BOX (hbox), frame, TRUE, TRUE, 0); gtk_box_pack_start (GTK_BOX (hbox), frame, TRUE, TRUE, 0);
#if !(defined(_WIN32)|| defined(__APPLE__))
/* hide eyedropper button -- which does not work on OSX:
* " the problem is worse than just `not getting the color' though.
* The action doesn't actually complete, and window focus is in a
* `weird state' until you click inside the color-picker dialog twice;
* then it all seems back to normal (but no color got picked)"
*
* On Windows 7 it works only in Ardour's own Window, but mouse cursor
* is offset, and it's virtually impossible to pick the correct color.
*/
button = gtk_button_new (); button = gtk_button_new ();
gtk_widget_set_events (button, GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK); gtk_widget_set_events (button, GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK);
@ -380,6 +391,7 @@ gtk_color_selection_init (GtkColorSelection *colorsel)
gtk_widget_set_tooltip_text (button, gtk_widget_set_tooltip_text (button,
_("Click the eyedropper, then click a color anywhere on your screen to select that color.")); _("Click the eyedropper, then click a color anywhere on your screen to select that color."));
#endif
top_right_vbox = gtk_vbox_new (FALSE, 6); top_right_vbox = gtk_vbox_new (FALSE, 6);
gtk_box_pack_start (GTK_BOX (top_hbox), top_right_vbox, FALSE, FALSE, 0); gtk_box_pack_start (GTK_BOX (top_hbox), top_right_vbox, FALSE, FALSE, 0);