smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-09 00:04:56 +01:00
Code Issues Projects Releases Wiki Activity

make comment about discovering plugins in the main thread more accurate

Browse source
This commit is contained in:
Paul Davis 2019-10-25 12:20:10 -06:00
parent c6b8fc78c8
commit a53448846b
1 changed files with 11 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

17
gtk2_ardour/plugin_scan_dialog.cc
View file

@ -84,12 +84,17 @@ PluginScanDialog::start ()
* read this and think about it carefully if you are confused. * read this and think about it carefully if you are confused.
* *
* Plugin discovery must take place in the main thread of the * Plugin discovery must take place in the main thread of the
* process. This is not true for all plugin APIs but it is true for VST * process. This is not true for all plugin APIs but it is true for
* and AU. This means that the PluginManager::refresh() call MUST be * VST. For AU, although plugins themselves do not care, Apple decided
* made from the main thread (typically the GUI thread, but certainly * that Cocoa must be "invoked" from the main thread, so if the plugin
* the thread running main()). Failure to do this will cause crashes, * decides to show any kind of "registration" GUI, then again,
* undefined behavior and other undesirable stuff (because plugin APIs * discovery must be done in the main thread.
* failed to specify this aspect of the host behavior). *
* This means that the PluginManager::refresh() call MUST be made from
* the main thread (typically the GUI thread, but certainly the thread
* running main()). Failure to do this will cause crashes, undefined
* behavior and other undesirable stuff (because plugin APIs failed to
* specify this aspect of the host behavior).
* *
* The ::refresh call is likely to be slow, particularly in the case of * The ::refresh call is likely to be slow, particularly in the case of
* VST(2) plugins where we are forced to load the shared object do * VST(2) plugins where we are forced to load the shared object do