From a30d526af0abe3973cb62efd29826ebc97a85945 Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Wed, 14 Sep 2022 20:49:04 +0200 Subject: [PATCH] Consistently color regions when using name bars With name-bars the region was colored using the track color if the region is not high enough to show the name-bar. This happened regardless of the color-regions-using-track-color preference IFF name-bars were enabled. However set_color/get_fill_color() is not called when the track-height changes "high_enough_for_name". This lead to inconsistently colored regions, some with a background some without. --- gtk2_ardour/time_axis_view_item.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gtk2_ardour/time_axis_view_item.cc b/gtk2_ardour/time_axis_view_item.cc index b282754584..a80d914e6f 100644 --- a/gtk2_ardour/time_axis_view_item.cc +++ b/gtk2_ardour/time_axis_view_item.cc @@ -685,8 +685,7 @@ TimeAxisViewItem::get_fill_color () const return UIConfiguration::instance().color ("selected region base"); } else if (_recregion) { return UIConfiguration::instance().color ("recording rect"); - } else if ((!UIConfiguration::instance().get_show_name_highlight() || high_enough_for_name) && - !UIConfiguration::instance().get_color_regions_using_track_color()) { + } else if (!UIConfiguration::instance().get_color_regions_using_track_color()) { return UIConfiguration::instance().color_mod (fill_color_name, mod_name); } return UIConfiguration::instance().color_mod (fill_color, mod_name);