From 9fd131fbaa0f5a58bb683e136f33db6d0bd0ceac Mon Sep 17 00:00:00 2001 From: Franke Burgarino Date: Tue, 26 Aug 2025 17:20:02 -0500 Subject: [PATCH] MCU: fix banking in the plugin subview the addition of the current bank to the global strip position was just causing the vpots to be off by the bank number, so past bank 1 the pots were tied to the wrong plugins --- libs/surfaces/mackie/subview.cc | 5 ----- 1 file changed, 5 deletions(-) diff --git a/libs/surfaces/mackie/subview.cc b/libs/surfaces/mackie/subview.cc index 4c2686e135..4e7e4e2848 100644 --- a/libs/surfaces/mackie/subview.cc +++ b/libs/surfaces/mackie/subview.cc @@ -1162,11 +1162,6 @@ void PluginSelect::setup_vpot( void PluginSelect::handle_vselect_event(uint32_t global_strip_position, std::shared_ptr subview_stripable) { - /* adjust global_strip_position to make sure we're accessing the - * correct controllable since we might be banked within the subview. - */ - global_strip_position += _current_bank; - /* PluginSelect mode: press selects the plugin shown on the strip's LCD */ if (!subview_stripable) { return;