smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-11 17:16:38 +01:00
Code Issues Projects Releases Wiki Activity

Prevent duplicate Ctrl-protocol instances

Browse source 
ControlProtocols are single instance.

Activating an already active protocol leads to crashes due to
various rasons (e.g. port already registered), re-used singleton
event_loop_name and request-buffers, duplicate free of
AbstractUI request buffers during deactivate,..
This commit is contained in:
Robin Gareus 2019-09-05 18:59:26 +02:00
parent 22e5c1de0d
commit 9bb2f2bb69
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
libs/ardour/control_protocol_manager.cc
View file

@ -129,6 +129,11 @@ ControlProtocolManager::activate (ControlProtocolInfo& cpi)
cpi.requested = true; cpi.requested = true;
if (cpi.protocol && cpi.protocol->active()) {
warning << string_compose (_("Control protocol %1 was already active."), cpi.name) << endmsg;
return 0;
}
if ((cp = instantiate (cpi)) == 0) { if ((cp = instantiate (cpi)) == 0) {
return -1; return -1;
} }