smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-06 23:05:04 +01:00
Code Issues Projects Releases Wiki Activity

avoid possible iterator corruption in MIDI region selection handling

Browse source
This commit is contained in:
Paul Davis 2021-03-18 12:49:51 -06:00
parent a2b1482cad
commit 985eb93674
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
gtk2_ardour/editor_selection.cc
View file

@ -1683,12 +1683,15 @@ Editor::select_all_internal_edit (Selection::Operation)
{ {
bool selected = false; bool selected = false;
for (RegionSelection::iterator i = selection->regions.begin(); i != selection->regions.end(); ++i) { for (RegionSelection::iterator i = selection->regions.begin(); i != selection->regions.end(); ) {
RegionSelection::iterator tmp = i;
++tmp;
MidiRegionView* mrv = dynamic_cast<MidiRegionView*>(*i); MidiRegionView* mrv = dynamic_cast<MidiRegionView*>(*i);
if (mrv) { if (mrv) {
mrv->select_all_notes (); mrv->select_all_notes ();
selected = true; selected = true;
} }
i = tmp;
} }
MidiRegionView* mrv = dynamic_cast<MidiRegionView*>(entered_regionview); MidiRegionView* mrv = dynamic_cast<MidiRegionView*>(entered_regionview);