smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-06 14:54:56 +01:00
Code Issues Projects Releases Wiki Activity

Properly solve d'tor order (controllable first) #8756

Browse source
This commit is contained in:
Robin Gareus 2021-06-21 19:59:40 +02:00
parent 43da7c6e6f
commit 96febb8f26
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
1 changed files with 15 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

15
libs/ardour/plugin_insert.cc
View file

@ -121,6 +121,21 @@ PluginInsert::drop_references ()
for (Plugins::iterator i = _plugins.begin(); i != _plugins.end(); ++i) { for (Plugins::iterator i = _plugins.begin(); i != _plugins.end(); ++i) {
(*i)->drop_references (); (*i)->drop_references ();
} }
/* PluginInsert::_plugins must exist until PBD::Controllable
* has emitted drop_references. This is because
* AC::get_value() calls _plugin[0]->get_parameter(..)
*
* Usually ~Automatable, calls drop_references for each
* controllable, but that runs after ~PluginInsert.
*/
{
Glib::Threads::Mutex::Lock lm (_control_lock);
for (Controls::const_iterator li = _controls.begin(); li != _controls.end(); ++li) {
boost::dynamic_pointer_cast<AutomationControl>(li->second)->drop_references ();
}
_controls.clear ();
}
Processor::drop_references (); Processor::drop_references ();
} }