smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-10 00:34:59 +01:00
Code Issues Projects Releases Wiki Activity

Revert "consistent use of context-menu popups"

Browse source 
This reverts commit b3722f7063.

In some cases ardour shows context-menu on right-mouse-button
release. In this case selecting a menu-entry should happen
with the left-mouse button (or any button?!)

Using ev->button is only correct if the menu is temporary and only
visible while the button is held, button release then activates the
menu-item.

This needs further work, in some cases allowing any button (0) to work
makes sense and overall consistency needs to be improved.
Different places use different strategies for context-menus which
don't always match the button used in the event-handler.

This is a hotfix (to make TAV context menus work again with left-click)
This commit is contained in:
Robin Gareus 2017-03-24 14:36:17 +01:00
parent 55b8b44889
commit 962e7a214a
13 changed files with 28 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

2
gtk2_ardour/processor_box.cc
View file

@ -2222,7 +2222,7 @@ ProcessorBox::show_processor_menu (int arg)
&& !boost::dynamic_pointer_cast<Amp> (single_selection->processor ())
&& !boost::dynamic_pointer_cast<UnknownProcessor> (single_selection->processor ()));
processor_menu->popup (3, arg);
processor_menu->popup (1, arg);
/* Add a placeholder gap to the processor list to indicate where a processor would be
inserted were one chosen from the menu.