diff --git a/gtk2_ardour/global_port_matrix.cc b/gtk2_ardour/global_port_matrix.cc index 0f107452a5..c303e3ce72 100644 --- a/gtk2_ardour/global_port_matrix.cc +++ b/gtk2_ardour/global_port_matrix.cc @@ -69,9 +69,14 @@ GlobalPortMatrix::set_state (ARDOUR::BundleChannel c[2], bool s) } else { q->disconnect (*i); } + } else { + /* two non-Ardour ports */ + if (s) { + jack_connect (_session.engine().jack (), j->c_str(), i->c_str()); + } else { + jack_disconnect (_session.engine().jack (), j->c_str(), i->c_str()); + } } - - /* we don't handle connections between two non-Ardour ports */ } } } @@ -84,7 +89,7 @@ GlobalPortMatrix::get_state (ARDOUR::BundleChannel c[2]) const if (in_ports.empty() || out_ports.empty()) { /* we're looking at a bundle with no parts associated with this channel, so nothing to connect */ - return PortMatrixNode::UNKNOWN; + return PortMatrixNode::NOT_ASSOCIATED; } for (ARDOUR::Bundle::PortList::const_iterator i = in_ports.begin(); i != in_ports.end(); ++i) { @@ -93,9 +98,31 @@ GlobalPortMatrix::get_state (ARDOUR::BundleChannel c[2]) const ARDOUR::Port* p = _session.engine().get_port_by_name (*i); ARDOUR::Port* q = _session.engine().get_port_by_name (*j); - /* we don't know the state of connections between two non-Ardour ports */ if (!p && !q) { - return PortMatrixNode::UNKNOWN; + /* two non-Ardour ports; things are slightly more involved */ + /* XXX: is this the easiest way to do this? */ + /* XXX: isn't this very inefficient? */ + + jack_client_t* jack = _session.engine().jack (); + jack_port_t* jp = jack_port_by_name (jack, i->c_str()); + if (jp == 0) { + return PortMatrixNode::NOT_ASSOCIATED; + } + + char const ** c = jack_port_get_all_connections (jack, jp); + + char const ** p = c; + + while (p && *p != 0) { + if (strcmp (*p, j->c_str()) == 0) { + free (c); + return PortMatrixNode::ASSOCIATED; + } + ++p; + } + + free (c); + return PortMatrixNode::NOT_ASSOCIATED; } if (p && p->connected_to (*j) == false) { diff --git a/gtk2_ardour/io_selector.cc b/gtk2_ardour/io_selector.cc index 68cd1c8408..a689fc666e 100644 --- a/gtk2_ardour/io_selector.cc +++ b/gtk2_ardour/io_selector.cc @@ -113,7 +113,7 @@ IOSelector::get_state (ARDOUR::BundleChannel c[2]) const if (our_ports.empty() || other_ports.empty()) { /* we're looking at a bundle with no parts associated with this channel, so nothing to connect */ - return PortMatrixNode::UNKNOWN; + return PortMatrixNode::NOT_ASSOCIATED; } for (ARDOUR::Bundle::PortList::const_iterator i = our_ports.begin(); i != our_ports.end(); ++i) { diff --git a/gtk2_ardour/port_matrix_grid.cc b/gtk2_ardour/port_matrix_grid.cc index 543efa91ca..b6be4165a9 100644 --- a/gtk2_ardour/port_matrix_grid.cc +++ b/gtk2_ardour/port_matrix_grid.cc @@ -166,9 +166,6 @@ PortMatrixGrid::render_group_pair (cairo_t* cr, boost::shared_ptrbundle, 0) )); switch (s) { - case PortMatrixNode::UNKNOWN: - draw_unknown_indicator (cr, bx, by); - break; case PortMatrixNode::ASSOCIATED: draw_association_indicator (cr, bx, by); break; @@ -210,10 +207,6 @@ PortMatrixGrid::render_group_pair (cairo_t* cr, boost::shared_ptr nodes_on_line (int, int, int, int) const; PortMatrixNode::State get_association (PortMatrixNode) const; void set_association (PortMatrixNode, bool); diff --git a/gtk2_ardour/port_matrix_types.h b/gtk2_ardour/port_matrix_types.h index f36821cd90..15c40713b0 100644 --- a/gtk2_ardour/port_matrix_types.h +++ b/gtk2_ardour/port_matrix_types.h @@ -40,7 +40,6 @@ struct PortMatrixNode enum State { ASSOCIATED, ///< the ports are associated NOT_ASSOCIATED, ///< the ports are not associated - UNKNOWN, ///< we don't know anything about these two ports' relationship PARTIAL ///< used when we are examining bundles; the bundles are partially associated }; };