From 9320a51c54d7a200c2023a89426b45e53b4841de Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Thu, 2 Oct 2025 02:00:14 +0200 Subject: [PATCH] Remove redundant calls to set params of replicated plugins This already happens in: PlugInsertBase::PluginControl::actually_set_value and PlugInsertBase::PluginPropertyControl::actually_set_value --- libs/ardour/plugin_insert.cc | 16 ---------------- libs/ardour/region_fx_plugin.cc | 17 ----------------- 2 files changed, 33 deletions(-) diff --git a/libs/ardour/plugin_insert.cc b/libs/ardour/plugin_insert.cc index 77c1a7bdec..2deac4e182 100644 --- a/libs/ardour/plugin_insert.cc +++ b/libs/ardour/plugin_insert.cc @@ -638,22 +638,6 @@ PluginInsert::parameter_changed_externally (uint32_t which, float val) pc->catch_up_with_external_value (val); } - /* Second propagation: tell all plugins except the first to - update the value of this parameter. For sane plugin APIs, - there are no other plugins, so this is a no-op in those - cases. - */ - - Plugins::iterator i = _plugins.begin(); - - /* don't set the first plugin, just all the slaves */ - - if (i != _plugins.end()) { - ++i; - for (; i != _plugins.end(); ++i) { - (*i)->set_parameter (which, val, 0); - } - } std::shared_ptr iasp = _impulseAnalysisPlugin.lock(); if (iasp) { iasp->set_parameter (which, val, 0); diff --git a/libs/ardour/region_fx_plugin.cc b/libs/ardour/region_fx_plugin.cc index ae080a76fd..4cc8ec1463 100644 --- a/libs/ardour/region_fx_plugin.cc +++ b/libs/ardour/region_fx_plugin.cc @@ -677,23 +677,6 @@ RegionFxPlugin::parameter_changed_externally (uint32_t which, float val) if (pc) { pc->catch_up_with_external_value (val); } - - /* Second propagation: tell all plugins except the first to - * update the value of this parameter. For sane plugin APIs, - * there are no other plugins, so this is a no-op in those - * cases. - */ - - Plugins::iterator i = _plugins.begin (); - - /* don't set the first plugin, just all the slaves */ - - if (i != _plugins.end ()) { - ++i; - for (; i != _plugins.end (); ++i) { - (*i)->set_parameter (which, val, 0); - } - } } void