smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-09 16:24:57 +01:00
Code Issues Projects Releases Wiki Activity

Remove redundant calls to set params of replicated plugins

Browse source 
This already happens in:
PlugInsertBase::PluginControl::actually_set_value
and
PlugInsertBase::PluginPropertyControl::actually_set_value
This commit is contained in:
Robin Gareus 2025-10-02 02:00:14 +02:00
parent ae6900d8af
commit 9320a51c54
2 changed files with 0 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

16
libs/ardour/plugin_insert.cc
View file

@ -638,22 +638,6 @@ PluginInsert::parameter_changed_externally (uint32_t which, float val)
pc->catch_up_with_external_value (val);
}
/* Second propagation: tell all plugins except the first to
update the value of this parameter. For sane plugin APIs,
there are no other plugins, so this is a no-op in those
cases.
*/
Plugins::iterator i = _plugins.begin();
/* don't set the first plugin, just all the slaves */
if (i != _plugins.end()) {
++i;
for (; i != _plugins.end(); ++i) {
(*i)->set_parameter (which, val, 0);
}
}
std::shared_ptr<Plugin> iasp = _impulseAnalysisPlugin.lock();
if (iasp) {
iasp->set_parameter (which, val, 0);

17
libs/ardour/region_fx_plugin.cc
View file

@ -677,23 +677,6 @@ RegionFxPlugin::parameter_changed_externally (uint32_t which, float val)
if (pc) {
pc->catch_up_with_external_value (val);
}
/* Second propagation: tell all plugins except the first to
* update the value of this parameter. For sane plugin APIs,
* there are no other plugins, so this is a no-op in those
* cases.
*/
Plugins::iterator i = _plugins.begin ();
/* don't set the first plugin, just all the slaves */
if (i != _plugins.end ()) {
++i;
for (; i != _plugins.end (); ++i) {
(*i)->set_parameter (which, val, 0);
}
}
}
void