smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2026-01-07 14:15:46 +01:00
Code Issues Projects Releases Wiki Activity

add commentary on why PublicEditor::{_,}ensure_time_axis_view_is_visible() both exist

Browse source
This commit is contained in:
Paul Davis 2014-06-27 10:48:04 -04:00
parent 66115ee7f7
commit 91fa5f7b2a
1 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

13
gtk2_ardour/public_editor.h
View file

@ -273,8 +273,10 @@ class PublicEditor : public Gtk::Window, public PBD::StatefulDestructible, publi
virtual framecnt_t current_page_samples() const = 0;
virtual double visible_canvas_height () const = 0;
virtual void temporal_zoom_step (bool coarser) = 0;
virtual void ensure_time_axis_view_is_visible (const TimeAxisView& tav, bool at_top = false) {
_ensure_time_axis_view_is_visible (tav, at_top);
/* The virtual version, without a default argument, is protected below.
*/
void ensure_time_axis_view_is_visible (TimeAxisView const & tav, bool at_top = false) {
_ensure_time_axis_view_is_visible (tav, at_top);
}
virtual void override_visible_track_count () = 0;
virtual void scroll_tracks_down_line () = 0;
@ -422,7 +424,12 @@ class PublicEditor : public Gtk::Window, public PBD::StatefulDestructible, publi
PBD::Signal0<void> MouseModeChanged;
protected:
virtual void _ensure_time_axis_view_is_visible (const TimeAxisView& tav, bool at_top) = 0;
/* This _ variant of ensure_time_axis_view_is_visible exists because
C++ doesn't really like default values for virtual methods. So the
public version is non-virtual, with a default value; the virtual
(and protected) method here does not have a default value.
*/
virtual void _ensure_time_axis_view_is_visible (TimeAxisView const & tav, bool at_top) = 0;
};
#endif // __gtk_ardour_public_editor_h__