smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2026-01-30 08:53:08 +01:00
Code Issues Projects Releases Wiki Activity

Fix Ferret when using onset detection + split

Browse source 
When not starting at a silent area, onset detection can have
a transient at 0 (region start). This needs to be ignored.
This commit is contained in:
Robin Gareus 2022-06-02 01:45:47 +02:00
parent 9ef9277d47
commit 8f074200cc
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
1 changed files with 11 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

17
gtk2_ardour/editor_ops.cc
View file

@ -7437,7 +7437,7 @@ Editor::split_region_at_points (boost::shared_ptr<Region> r, AnalysisFeatureList
pl->freeze ();
pl->remove_region (r);
timepos_t pos;
timepos_t pos (AudioTime);
const timepos_t rstart = r->position ();
const samplepos_t start_sample = r->position_sample();
@ -7456,16 +7456,21 @@ Editor::split_region_at_points (boost::shared_ptr<Region> r, AnalysisFeatureList
timepos_t file_start = r->start() + pos;
/* length = next position - current position */
/* length = next position - current position
* len = (*x) - pos - rstart;
*/
timecnt_t len = pos.distance (timepos_t (*x)) - rstart;
/* XXX we do we really want to allow even single-sample regions?
* shouldn't we have some kind of lower limit on region size?
/* Transient and Onset analysis has a min gap size, but
* user placed transients can be placed every sample.
*
* We might want to have a lower limit on the region size.
*/
if (len.is_zero () || len.is_negative()) {
break;
if (!len.is_positive ()) {
++x;
continue;
}
string new_name;