From 8a47dc39f1c068ddd9dda5d35464a2e15d3296b4 Mon Sep 17 00:00:00 2001 From: Paul Davis Date: Mon, 1 Feb 2021 12:15:55 -0700 Subject: [PATCH] remove NUTEMPO warning by replacing with an explanatory comment --- libs/ardour/region.cc | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/libs/ardour/region.cc b/libs/ardour/region.cc index fae1e2d066..ba99bdb05f 100644 --- a/libs/ardour/region.cc +++ b/libs/ardour/region.cc @@ -602,6 +602,10 @@ Region::update_after_tempo_map_change (bool send) return; } + /* a region using AudioTime is never going to move after a tempo map + * change + */ + if (_position.val().time_domain() == Temporal::AudioTime) { return; } @@ -612,7 +616,15 @@ Region::update_after_tempo_map_change (bool send) PropertyChange what_changed; -#warning NUTEMPO THINKME make this more nuanced ... nothing may have changed and maybe we do not need this at all + /* any or none of these may have changed due to a tempo map change, + but we have no way to establish which have changed and which have + not. So we have to mention all 3 to be certain that listeners pay + attention. We can't verify because we have no cache of our old + start/length/position values in the audio domain, so we can't + compare the new values in the audio domain. The beat domain values + haven't changed (just the tempo map that connects beat and audio + time) + */ what_changed.add (Properties::start); what_changed.add (Properties::length); @@ -799,7 +811,7 @@ Region::move_start (timecnt_t const & distance) return; } - timecnt_t new_start (_start); + timecnt_t new_start (_start); if (distance.positive()) {