smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-10 08:36:32 +01:00
Code Issues Projects Releases Wiki Activity

Constrain variable scopen and avoid uninitialized values existing at all.

Browse source 
Note: dead assignments trigger scan-build dead code warnings, which
initializations do not.
This commit is contained in:
David Robillard 2014-11-18 02:34:18 -05:00
parent 6e482b3488
commit 881d77f1e5
1 changed files with 4 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

11
libs/ardour/rb_effect.cc
View file

@ -72,7 +72,6 @@ RBEffect::run (boost::shared_ptr<Region> r, Progress* progress)
} }
SourceList nsrcs; SourceList nsrcs;
framecnt_t done;
int ret = -1; int ret = -1;
const framecnt_t bufsize = 256; const framecnt_t bufsize = 256;
gain_t* gain_buffer = 0; gain_t* gain_buffer = 0;
@ -80,8 +79,6 @@ RBEffect::run (boost::shared_ptr<Region> r, Progress* progress)
char suffix[32]; char suffix[32];
string new_name; string new_name;
string::size_type at; string::size_type at;
framepos_t pos = 0;
framecnt_t avail = 0;
boost::shared_ptr<AudioRegion> result; boost::shared_ptr<AudioRegion> result;
cerr << "RBEffect: source region: position = " << region->position() cerr << "RBEffect: source region: position = " << region->position()
@ -184,6 +181,10 @@ RBEffect::run (boost::shared_ptr<Region> r, Progress* progress)
/* create new sources */ /* create new sources */
framepos_t pos = 0;
framecnt_t avail = 0;
framecnt_t done = 0;
if (make_new_sources (region, nsrcs, suffix)) { if (make_new_sources (region, nsrcs, suffix)) {
goto out; goto out;
} }
@ -201,10 +202,6 @@ RBEffect::run (boost::shared_ptr<Region> r, Progress* progress)
/* study first, process afterwards. */ /* study first, process afterwards. */
pos = 0;
avail = 0;
done = 0;
try { try {
while (pos < read_duration && !tsr.cancel) { while (pos < read_duration && !tsr.cancel) {