Do not save export format for indirect changes

Previously selecting a different export format that changed global
settings (eg. toggle analysis) triggered an indirect save of the format.
This commit is contained in:
Robin Gareus 2019-02-26 19:57:02 +01:00
parent 47c265f2ec
commit 85877adf56
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
2 changed files with 14 additions and 2 deletions

View file

@ -260,8 +260,8 @@ ExportFileNotebook::FilePage::FilePage (Session * s, ManagerPtr profile_manager,
sigc::mem_fun (*this, &ExportFileNotebook::FilePage::critical_selection_changed));
soundcloud_upload_button.signal_toggled().connect (sigc::mem_fun (*parent, &ExportFileNotebook::update_soundcloud_upload));
soundcloud_upload_button.signal_toggled().connect (sigc::mem_fun (*this, &ExportFileNotebook::FilePage::soundcloud_upload_changed));
analysis_button.signal_toggled().connect (sigc::mem_fun (*this, &ExportFileNotebook::FilePage::analysis_changed));
soundcloud_button_connection = soundcloud_upload_button.signal_toggled().connect (sigc::mem_fun (*this, &ExportFileNotebook::FilePage::soundcloud_upload_changed));
analysis_button_connection = analysis_button.signal_toggled().connect (sigc::mem_fun (*this, &ExportFileNotebook::FilePage::analysis_changed));
/* Tab widget */
tab_close_button.add (*Gtk::manage (new Gtk::Image (::get_icon("close"))));
@ -361,7 +361,15 @@ ExportFileNotebook::FilePage::critical_selection_changed ()
{
update_tab_label();
update_example_filename();
soundcloud_button_connection.block ();
analysis_button_connection.block ();
update_analysis_button();
update_soundcloud_upload_button();
analysis_button_connection.unblock ();
soundcloud_button_connection.unblock ();
CriticalSelectionChanged();
}

View file

@ -128,7 +128,11 @@ private:
Gtk::Label tab_label;
Gtk::Alignment tab_close_alignment;
Gtk::Button tab_close_button;
uint32_t tab_number;
sigc::connection soundcloud_button_connection;
sigc::connection analysis_button_connection;
};
};