From 834e164df088cf3ef1d32baf460f3a8224d2dcbf Mon Sep 17 00:00:00 2001
From: Robin Gareus <robin@gareus.org>
Date: Fri, 4 Feb 2022 13:57:33 +0100
Subject: [PATCH] Trigger Clip Picker: Idle update audition synth

This keeps the plugin in sync with any changes made to the
Plugin UI. In particular General MIDI Synth will send
notifications once patch/program changes are processed.
ACE Fluidsynth can load sf2 files, etc.
---
 gtk2_ardour/trigger_clip_picker.cc | 30 ++++++++++++++++++++++++++++++
 gtk2_ardour/trigger_clip_picker.h  |  3 +++
 2 files changed, 33 insertions(+)

diff --git a/gtk2_ardour/trigger_clip_picker.cc b/gtk2_ardour/trigger_clip_picker.cc
index 2bdfbdb88f..20ca011319 100644
--- a/gtk2_ardour/trigger_clip_picker.cc
+++ b/gtk2_ardour/trigger_clip_picker.cc
@@ -49,7 +49,9 @@
 #include "widgets/tooltips.h"
 #include "widgets/ardour_icon.h"
 
+#include "ardour_ui.h"
 #include "plugin_ui.h"
+#include "timers.h"
 #include "trigger_clip_picker.h"
 #include "ui_config.h"
 
@@ -188,6 +190,7 @@ TriggerClipPicker::TriggerClipPicker ()
 
 TriggerClipPicker::~TriggerClipPicker ()
 {
+	_idle_connection.disconnect ();
 }
 
 void
@@ -853,6 +856,29 @@ TriggerClipPicker::audition (std::string const& path)
 	_session->audition_region (r);
 }
 
+void
+TriggerClipPicker::audition_processor_idle ()
+{
+	if (!_session || _session->deletion_in_progress () || !_session->the_auditioner ()) {
+		return;
+	}
+	assert (_session && _session->the_auditioner ());
+	ARDOUR_UI::instance ()->get_process_buffers ();
+	_session->the_auditioner ()->idle_synth_update ();
+	ARDOUR_UI::instance ()->drop_process_buffers ();
+}
+
+bool
+TriggerClipPicker::audition_processor_viz (bool show)
+{
+	if (show) {
+		_idle_connection = Timers::fps_connect (sigc::mem_fun (*this, &TriggerClipPicker::audition_processor_idle));
+	} else {
+		_idle_connection.disconnect ();
+	}
+	return false;
+}
+
 void
 TriggerClipPicker::audition_show_plugin_ui ()
 {
@@ -864,6 +890,9 @@ TriggerClipPicker::audition_show_plugin_ui ()
 			_audition_plugnui->show_all ();
 			_audition_plugnui->set_title (/* generate_processor_title (plugin_insert)*/ _("Audition Synth"));
 			plugin_insert->DropReferences.connect (_processor_connections, invalidator (*this), boost::bind (&TriggerClipPicker::audition_processor_going_away, this), gui_context());
+
+			_audition_plugnui->signal_map_event ().connect (sigc::hide (sigc::bind (sigc::mem_fun (*this, &TriggerClipPicker::audition_processor_viz), true)));
+			_audition_plugnui->signal_unmap_event ().connect (sigc::hide (sigc::bind (sigc::mem_fun (*this, &TriggerClipPicker::audition_processor_viz), false)));
 		}
 	}
 	if (_audition_plugnui) {
@@ -875,6 +904,7 @@ void
 TriggerClipPicker::audition_processor_going_away ()
 {
 	if (_audition_plugnui) {
+		_idle_connection.disconnect ();
 		delete _audition_plugnui;
 	}
 	_audition_plugnui = 0;
diff --git a/gtk2_ardour/trigger_clip_picker.h b/gtk2_ardour/trigger_clip_picker.h
index f31dbdce94..b351be68a1 100644
--- a/gtk2_ardour/trigger_clip_picker.h
+++ b/gtk2_ardour/trigger_clip_picker.h
@@ -72,6 +72,8 @@ private:
 	void audition_progress (ARDOUR::samplecnt_t, ARDOUR::samplecnt_t);
 	void audition_processors_changed ();
 	void audition_processor_going_away ();
+	void audition_processor_idle ();
+	bool audition_processor_viz (bool);
 	void audition_show_plugin_ui ();
 	void stop_audition ();
 	void autoplay_toggled ();
@@ -122,6 +124,7 @@ private:
 	PBD::ScopedConnectionList _processor_connections;
 	PBD::ScopedConnection     _config_connection;
 	PBD::ScopedConnection     _clip_added_connection;
+	sigc::connection          _idle_connection;
 };
 
 #endif