smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2026-01-06 21:55:43 +01:00
Code Issues Projects Releases Wiki Activity

Use port enumeration instead of manual indexed loop

Browse source
This commit is contained in:
Julien "_FrnchFrgg_" RIVAUD 2017-08-21 18:04:25 +02:00
parent ce9bdd1db0
commit 8119026bc8
1 changed files with 2 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

17
gtk2_ardour/mixer_strip.cc
View file

@ -1284,10 +1284,6 @@ MixerStrip::guess_main_type(bool for_input, bool favor_connected) const
void
MixerStrip::update_io_button (bool for_input)
{
uint32_t io_count;
uint32_t io_index;
boost::shared_ptr<IO> io;
boost::shared_ptr<Port> port;
vector<string> port_connections;
uint32_t total_connection_count = 0;
@ -1313,14 +1309,6 @@ MixerStrip::update_io_button (bool for_input)
DataType dt = guess_main_type(for_input);
if (for_input) {
io = _route->input();
} else {
io = _route->output();
}
io_count = io->n_ports().n_total();
if ( dt == DataType::MIDI ) {
tooltip << _("MIDI ");
}
@ -1331,9 +1319,8 @@ MixerStrip::update_io_button (bool for_input)
tooltip << string_compose (_("<b>OUTPUT</b> from %1"), Gtkmm2ext::markup_escape_text (_route->name()));
}
for (io_index = 0; io_index < io_count; ++io_index) {
port = io->nth (io_index);
boost::shared_ptr<IO> io = for_input ? _route->input() : _route->output();
for (PortSet::iterator port = io->ports().begin(); port != io->ports().end(); ++port) {
port_connections.clear ();
port->get_connections(port_connections);