smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-19 13:16:27 +01:00
Code Issues Projects Releases Wiki Activity

Prefix all env variable with "ARDOUR_"

Browse source 
In particular "CONCURRENCY" can be problematic. But in general
it's good practice to use a namespace prefix for app-specifics.
This commit is contained in:
Robin Gareus 2019-07-26 16:44:29 +02:00
parent b759fb883e
commit 78fc6d6651
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
6 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
libs/ardour/ardour/dsp_load_calculator.h
View file

@ -73,7 +73,7 @@ public:
} }
#ifndef NDEBUG #ifndef NDEBUG
const bool calc_avg_load = NULL != getenv("AVGLOAD"); const bool calc_avg_load = NULL != getenv("ARDOUR_AVG_DSP_LOAD");
#else #else
const bool calc_avg_load = false; const bool calc_avg_load = false;
#endif #endif

2
libs/ardour/globals.cc
View file

@ -439,7 +439,7 @@ ARDOUR::init (bool use_windows_vst, bool try_optimization, const char* localedir
} }
#ifndef NDEBUG #ifndef NDEBUG
if (getenv("LUA_METATABLES")) { if (getenv("ARDOUR_LUA_METATABLES")) {
luabridge::Security::setHideMetatables (false); luabridge::Security::setHideMetatables (false);
} }
#endif #endif

6
libs/backends/alsa/alsa_audiobackend.cc
View file

@ -958,10 +958,10 @@ AlsaAudioBackend::_start (bool for_latency_measurement)
_midi_device_thread_active = listen_for_midi_device_changes (); _midi_device_thread_active = listen_for_midi_device_changes ();
#if 1 #if 1 // TODO: we need a GUI (and API) for this
if (NULL != getenv ("ALSAEXT")) { if (NULL != getenv ("ARDOUR_ALSA_EXT")) {
boost::char_separator<char> sep (";"); boost::char_separator<char> sep (";");
boost::tokenizer<boost::char_separator<char> > devs (std::string(getenv ("ALSAEXT")), sep); boost::tokenizer<boost::char_separator<char> > devs (std::string(getenv ("ARDOUR_ALSA_EXT")), sep);
BOOST_FOREACH (const std::string& tmp, devs) { BOOST_FOREACH (const std::string& tmp, devs) {
std::string dev (tmp); std::string dev (tmp);
std::string::size_type n = dev.find ('@'); std::string::size_type n = dev.find ('@');

2
libs/backends/coreaudio/coremidi_io.cc
View file

@ -153,7 +153,7 @@ CoreMidiIo::CoreMidiIo()
pthread_mutex_init (&_discovery_lock, 0); pthread_mutex_init (&_discovery_lock, 0);
#ifndef NDEBUG #ifndef NDEBUG
const char *p = getenv ("COREMIDIDEBUG"); const char *p = getenv ("ARDOUR_COREMIDI_DEBUG");
if (p && *p) _debug_mode = atoi (p); if (p && *p) _debug_mode = atoi (p);
#endif #endif
} }

4
libs/pbd/cpus.cc
View file

@ -43,8 +43,8 @@
uint32_t uint32_t
hardware_concurrency() hardware_concurrency()
{ {
if (getenv("CONCURRENCY")) { if (getenv("ARDOUR_CONCURRENCY")) {
int c = atoi (getenv("CONCURRENCY")); int c = atoi (getenv("ARDOUR_CONCURRENCY"));
if (c > 0) { if (c > 0) {
return c; return c;
} }

2
libs/widgets/fastmeter.cc
View file

@ -74,7 +74,7 @@ FastMeter::FastMeter (long hold, unsigned long dimen, Orientation o, int len,
last_peak_rect.x = 0; last_peak_rect.x = 0;
last_peak_rect.y = 0; last_peak_rect.y = 0;
no_rgba_overlay = ! Glib::getenv("NO_METER_SHADE").empty(); no_rgba_overlay = ! Glib::getenv("ARDOUR_NO_METER_SHADE").empty();
_clr[0] = clr0; _clr[0] = clr0;
_clr[1] = clr1; _clr[1] = clr1;