smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-09 08:14:58 +01:00
Code Issues Projects Releases Wiki Activity

audio_backend: Rename instantiate() parameter arg2 to session_id

Browse source 
The thing called backend_client_name defaulted to lowercase PROGRAM_NAME
and could be controlled with:

    -c, --name <name>           Use a specific backend client name, default is ardour

This value was *only* used for set_backend arg2 which only is used for
jack, where it was called session_uuid and passed to jack_client_open as
"a SessionID Token this allows the sessionmanager to identify the client
again" because JackSessionID.

It is certainly misleading to call it a uuid. It also doesn't seem
helpful to call it "client name" when the documentation calls it
"session id". And mostly: jack_client_open calls its *first* argument
"client_name" and it comes from argv1.

To clear things up, consistently call it something with "session id".
And it is not helpful to use a generic arg2 naming.
This commit is contained in:
Mads Kiilerich 2024-10-20 18:44:43 +02:00
parent 9c0c4f527b
commit 710bd07cd4
17 changed files with 35 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

4
libs/backends/coreaudio/coreaudio_backend.cc
View file

@ -1529,7 +1529,7 @@ CoreAudioBackend::hw_changed_callback ()
static std::shared_ptr<CoreAudioBackend> _instance;
static std::shared_ptr<AudioBackend> backend_factory (AudioEngine& e);
static int instantiate (const std::string& arg1, const std::string& /* arg2 */);
static int instantiate (const std::string& arg1, const std::string& /* session_id */);
static int deinstantiate ();
static bool already_configured ();
static bool available ();
@ -1553,7 +1553,7 @@ backend_factory (AudioEngine& e)
}
static int
instantiate (const std::string& arg1, const std::string& /* arg2 */)
instantiate (const std::string& arg1, const std::string& /* session_id */)
{
s_instance_name = arg1;
return 0;