smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-08 15:54:57 +01:00
Code Issues Projects Releases Wiki Activity

Fix transient parent for plugin windows w/detached mixer

Browse source 
This follows f3fbf58185 which unconditionally set the main window
as transient parent. However when detaching the mixer, plugins should
be transient for the detached parent window.
This commit is contained in:
Robin Gareus 2020-11-16 15:47:05 +01:00
parent 3c25281203
commit 6dc91348d7
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
1 changed files with 17 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

17
gtk2_ardour/processor_box.cc
View file

@ -4238,6 +4238,10 @@ ProcessorBox::edit_processor (boost::shared_ptr<Processor> processor)
if (proxy) { if (proxy) {
proxy->set_custom_ui_mode (true); proxy->set_custom_ui_mode (true);
proxy->show_the_right_window (); proxy->show_the_right_window ();
Gtk::Window* tlw = dynamic_cast<Gtk::Window*> (get_toplevel ());
assert (tlw && proxy->get (false));
proxy->get ()->set_transient_for (*tlw);
} }
} }
@ -4259,6 +4263,10 @@ ProcessorBox::generic_edit_processor (boost::shared_ptr<Processor> processor)
if (proxy) { if (proxy) {
proxy->set_custom_ui_mode (false); proxy->set_custom_ui_mode (false);
proxy->show_the_right_window (); proxy->show_the_right_window ();
Gtk::Window* tlw = dynamic_cast<Gtk::Window*> (get_toplevel ());
assert (tlw && proxy->get (false));
proxy->get ()->set_transient_for (*tlw);
} }
} }
@ -4272,6 +4280,10 @@ ProcessorBox::manage_pins (boost::shared_ptr<Processor> processor)
if (proxy) { if (proxy) {
proxy->get (true); proxy->get (true);
proxy->present(); proxy->present();
Gtk::Window* tlw = dynamic_cast<Gtk::Window*> (get_toplevel ());
assert (tlw);
proxy->get ()->set_transient_for (*tlw);
} }
} }
@ -4557,6 +4569,11 @@ ProcessorWindowProxy::show_the_right_window (bool show_not_toggle)
return; return;
} }
toggle (); toggle ();
if (_window) {
/* clear any transients if window is toggled externally (ctrl surfaces) */
_window->unset_transient_for ();
}
} }