smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2026-01-07 22:25:46 +01:00
Code Issues Projects Releases Wiki Activity

Fix VST3 processor refcount

Browse source 
This fixes an issue with JUCE plugins remaining alive
after closing the session (and causing issues at exit).
see also 789949ed8e
This commit is contained in:
Robin Gareus 2022-03-20 15:37:51 +01:00
parent 0aabdc0849
commit 6bcc0163cd
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
2 changed files with 3 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
libs/ardour/ardour/vst3_plugin.h
View file

@ -237,8 +237,8 @@ private:
Linux::IRunLoop* _run_loop;
#endif
FUnknownPtr<Vst::IAudioProcessor> _processor;
Vst::ProcessContext _context;
IPtr<Vst::IAudioProcessor> _processor;
Vst::ProcessContext _context;
/* Parameters */
Vst3ParameterChanges _input_param_changes;

5
libs/ardour/vst3_plugin.cc
View file

@ -1103,7 +1103,7 @@ VST3PI::VST3PI (boost::shared_ptr<ARDOUR::VST3PluginModule> m, std::string uniqu
throw failed_constructor ();
}
if (!(_processor = FUnknownPtr<Vst::IAudioProcessor> (_component).take ())) {
if (!(_processor = FUnknownPtr<Vst::IAudioProcessor> (_component))) {
_controller->terminate ();
_controller->release ();
_component->terminate ();
@ -1111,8 +1111,6 @@ VST3PI::VST3PI (boost::shared_ptr<ARDOUR::VST3PluginModule> m, std::string uniqu
throw failed_constructor ();
}
_processor->addRef ();
/* prepare process context */
memset (&_context, 0, sizeof (Vst::ProcessContext));
@ -1242,7 +1240,6 @@ VST3PI::terminate ()
deactivate ();
_processor->release ();
_processor = 0;
disconnect_components ();