From 648e8f9f007b32b0e5c78fbfbeaef3b744248ad5 Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Fri, 15 Aug 2025 18:53:05 +0200 Subject: [PATCH] Fix use-after free, and double-packing of proc-box (amend 844d45896) --- gtk2_ardour/route_properties_box.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gtk2_ardour/route_properties_box.cc b/gtk2_ardour/route_properties_box.cc index 9ebdca7b85..f4ea5aecdd 100644 --- a/gtk2_ardour/route_properties_box.cc +++ b/gtk2_ardour/route_properties_box.cc @@ -81,6 +81,7 @@ RoutePropertiesBox::session_going_away () ENSURE_GUI_THREAD (*this, &RoutePropertiesBox::session_going_away); SessionHandlePtr::session_going_away (); + _insert_frame.remove (); drop_plugin_uis (); drop_route (); delete _insert_box; @@ -98,6 +99,7 @@ RoutePropertiesBox::set_session (ARDOUR::Session* s) { _insert_box->show_all (); float ui_scale = std::max (1.f, UIConfiguration::instance().get_ui_scale()); + _insert_frame.remove (); _insert_frame.add (*_insert_box); _insert_frame.set_padding (4); _insert_frame.set_size_request (144 * ui_scale, 236 * ui_scale);